Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4620)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java

Issue 2309403002: Use the URL passed to navigator.share(). (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java
index 110ce20bf50d2840001ec7ad3a5c2f579ed48566..f33dd2b2e996bb47c25ca8ce81934fd912d3aeff 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java
@@ -12,6 +12,7 @@ import org.chromium.chrome.browser.share.ShareHelper;
import org.chromium.content.browser.ContentViewCore;
import org.chromium.content_public.browser.WebContents;
import org.chromium.mojo.system.MojoException;
+import org.chromium.mojom.url.mojom.Url;
import org.chromium.mojom.webshare.ShareService;
import org.chromium.ui.base.WindowAndroid;
@@ -33,7 +34,7 @@ public class ShareServiceImpl implements ShareService {
public void onConnectionError(MojoException e) {}
@Override
- public void share(String title, String text, final ShareResponse callback) {
+ public void share(String title, String text, Url url, final ShareResponse callback) {
if (mActivity == null) {
callback.call("Share failed");
return;
@@ -45,7 +46,7 @@ public class ShareServiceImpl implements ShareService {
}
};
- ShareHelper.share(false, false, mActivity, title, text, null, null, null, innerCallback);
+ ShareHelper.share(false, false, mActivity, title, text, url.url, null, null, innerCallback);
}
@Nullable

Powered by Google App Engine
This is Rietveld 408576698