Use OffTheRecord version when using Guest profiles to handle commands.

chrome/browser/app_controller_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/app_controller_mac.h"
 
 #include "apps/app_shim/app_shim_mac.h"
 #include "apps/app_shim/extension_app_shim_handler_mac.h"
 #include "apps/app_window_registry.h"
 #include "base/auto_reset.h"
@@ skipping 937 matching lines @@
   }
   return enable;
 }
 
 // Called when the user picks a menu item when there are no key windows, or when
 // there is no foreground browser window. Calls through to the browser object to
 // execute the command. This assumes that the command is supported and doesn't
 // check, otherwise it should have been disabled in the UI in
 // |-validateUserInterfaceItem:|.
 - (void)commandDispatch:(id)sender {
-  Profile* lastProfile = [self lastProfile];
+  Profile* lastProfile = [self safeLastProfileForNewWindows];
 
   // Handle the case where we're dispatching a command from a sender that's in a
   // browser window. This means that the command came from a background window
   // and is getting here because the foreground window is not a browser window.
   if ([sender respondsToSelector:@selector(window)]) {
     id delegate = [[sender window] windowController];
     if ([delegate isKindOfClass:[BrowserWindowController class]]) {
       [delegate commandDispatch:sender];
       return;
     }
@@ skipping 314 matching lines @@
   // the initial profile.
   ProfileManager* profile_manager = g_browser_process->profile_manager();
   if (!profile_manager)
     return NULL;
 
   return profile_manager->GetProfile(GetStartupProfilePath(
       profile_manager->user_data_dir(),
       *CommandLine::ForCurrentProcess()));
 }
 
+- (Profile*)safeLastProfileForNewWindows {
+  Profile* profile = [self lastProfile];
+
+  // Guest sessions must always be OffTheRecord. Use that when opening windows.
+  if (profile->IsGuestSession())
+    return profile->GetOffTheRecordProfile();
+
+  return profile;
+}
+
 // Various methods to open URLs that we get in a native fashion. We use
 // StartupBrowserCreator here because on the other platforms, URLs to open come
 // through the ProcessSingleton, and it calls StartupBrowserCreator. It's best
 // to bottleneck the openings through that for uniform handling.
 
 - (void)openUrls:(const std::vector<GURL>&)urls {
   // If the browser hasn't started yet, just queue up the URLs.
   if (!startupComplete_) {
     startupUrls_.insert(startupUrls_.end(), urls.begin(), urls.end());
     return;
@@ skipping 43 matching lines @@
 }
 
 // Show the preferences window, or bring it to the front if it's already
 // visible.
 - (IBAction)showPreferences:(id)sender {
   if (Browser* browser = ActivateBrowser([self lastProfile])) {
     // Show options tab in the active browser window.
     chrome::ShowSettings(browser);
   } else {
     // No browser window, so create one for the options tab.
-    chrome::OpenOptionsWindow([self lastProfile]);
+    chrome::OpenOptionsWindow([self safeLastProfileForNewWindows]);
   }
 }
 
 - (IBAction)orderFrontStandardAboutPanel:(id)sender {
   if (Browser* browser = ActivateBrowser([self lastProfile])) {
     chrome::ShowAboutChrome(browser);
   } else {
     // No browser window, so create one for the about tab.
-    chrome::OpenAboutWindow([self lastProfile]);
+    chrome::OpenAboutWindow([self safeLastProfileForNewWindows]);
   }
 }
 
 - (IBAction)toggleConfirmToQuit:(id)sender {
   PrefService* prefService = g_browser_process->local_state();
   bool enabled = prefService->GetBoolean(prefs::kConfirmToQuitEnabled);
   prefService->SetBoolean(prefs::kConfirmToQuitEnabled, !enabled);
 }
 
 // Explicitly bring to the foreground when creating new windows from the dock.
@@ skipping 109 matching lines @@
 
 //---------------------------------------------------------------------------
 
 namespace app_controller_mac {
 
 bool IsOpeningNewWindow() {
   return g_is_opening_new_window;
 }
 
 }  // namespace app_controller_mac