Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2309153002: Remove RenderThreadImpl::Shutdown (Closed)

Created:
4 years, 3 months ago by haraken
Modified:
3 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove RenderThreadImpl::Shutdown RenderThreadImpl::Shutdown has been shutting down Blink and V8 gracefully, but the graceful shutdown has caused tons of use-after-free bugs (and many engineers has spent lots of time fixing ordering issues around the shutdown). As discussed in chromium-dev@ (https://groups.google.com/a/chromium.org/d/topic/chromium-dev/OLS4JSZvowI/discussion) and platform-architecture-dev@ (https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/Zc12k91NTFk/discussion), there is no reason we have to shut down the renderer gracefully. It's just causing use-after-free bugs and wasting performance. Hence this CL removes RenderThreadImpl::Shutdown and instead calls _exit(0) in ~ChildProcess. We need a couple of special handling in a single-process mode. See the comment in ~ChildProcess for more details. BUG=639244 Review-Url: https://codereview.chromium.org/2309153002 Cr-Commit-Position: refs/heads/master@{#443175} Committed: https://chromium.googlesource.com/chromium/src/+/bbfdd9f0669c9856883ffbf2cd9909e2a4df9dcf

Patch Set 1 #

Patch Set 2 : temp #

Patch Set 3 : temp #

Patch Set 4 : temp #

Patch Set 5 : temp #

Total comments: 1

Patch Set 6 : temp #

Patch Set 7 : temp #

Patch Set 8 : temp #

Patch Set 9 : temp #

Patch Set 10 : temp #

Patch Set 11 : temp #

Patch Set 12 : temp #

Patch Set 13 : temp #

Patch Set 14 : temp #

Patch Set 15 : temp #

Patch Set 16 : temp #

Patch Set 17 : temp #

Patch Set 18 : temp #

Patch Set 19 : temp #

Patch Set 20 : temp #

Patch Set 21 : temp #

Patch Set 22 : temp #

Patch Set 23 : temp #

Patch Set 24 : temp #

Patch Set 25 : temp #

Patch Set 26 : temp #

Patch Set 27 : temp #

Patch Set 28 : temp #

Patch Set 29 : temp #

Patch Set 30 : temp #

Patch Set 31 : temp #

Patch Set 32 : temp #

Patch Set 33 : temp #

Patch Set 34 : temp #

Patch Set 35 : temp #

Patch Set 36 : temp #

Patch Set 37 : temp #

Patch Set 38 : temp #

Patch Set 39 : temp #

Patch Set 40 : temp #

Patch Set 41 : temp #

Patch Set 42 : temp #

Patch Set 43 : temp #

Patch Set 44 : temp #

Patch Set 45 : temp #

Patch Set 46 : temp #

Patch Set 47 : temp #

Patch Set 48 : temp #

Patch Set 49 : temp #

Patch Set 50 : temp #

Patch Set 51 : temp #

Patch Set 52 : temp #

Patch Set 53 : temp #

Patch Set 54 : temp #

Patch Set 55 : temp #

Patch Set 56 : temp #

Patch Set 57 : temp #

Patch Set 58 : temp #

Patch Set 59 : temp #

Patch Set 60 : temp #

Total comments: 8

Patch Set 61 : temp #

Patch Set 62 : temp #

Total comments: 2

Patch Set 63 : temp #

Total comments: 1

Patch Set 64 : temp #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -131 lines) Patch
M base/at_exit.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 1 chunk +4 lines, -0 lines 0 comments Download
M base/at_exit.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 3 chunks +9 lines, -1 line 0 comments Download
M content/child/child_process.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 1 chunk +7 lines, -3 lines 0 comments Download
M content/child/child_thread_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 1 chunk +2 lines, -0 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 2 chunks +26 lines, -126 lines 1 comment Download
M content/renderer/render_thread_impl_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 3 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/ThreadSpecific.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 311 (235 generated)
haraken
primiano: FYI Only SingleProcessMemoryTracingTests that use WillOnce or WillRepeatedly are failing. It looks like that ...
4 years, 3 months ago (2016-09-08 09:02:44 UTC) #22
Primiano Tucci (use gerrit)
On 2016/09/08 09:02:44, haraken wrote: > primiano: FYI > > Only SingleProcessMemoryTracingTests that use WillOnce ...
4 years, 3 months ago (2016-09-08 11:16:36 UTC) #23
haraken
On 2016/09/08 11:16:36, Primiano Tucci wrote: > On 2016/09/08 09:02:44, haraken wrote: > > primiano: ...
4 years, 3 months ago (2016-09-08 13:24:53 UTC) #25
Torne
On 2016/09/08 13:24:53, haraken wrote: > On 2016/09/08 11:16:36, Primiano Tucci wrote: > > On ...
4 years, 3 months ago (2016-09-08 13:56:02 UTC) #26
Torne
https://codereview.chromium.org/2309153002/diff/80001/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/2309153002/diff/80001/content/renderer/render_thread_impl.cc#newcode865 content/renderer/render_thread_impl.cc:865: exit(0); One more comment while I think of it: ...
4 years, 3 months ago (2016-09-13 15:08:08 UTC) #27
haraken
On 2016/09/13 15:08:08, Torne wrote: > https://codereview.chromium.org/2309153002/diff/80001/content/renderer/render_thread_impl.cc > File content/renderer/render_thread_impl.cc (right): > > https://codereview.chromium.org/2309153002/diff/80001/content/renderer/render_thread_impl.cc#newcode865 > ...
4 years, 3 months ago (2016-09-15 12:42:40 UTC) #28
Torne
On 2016/09/15 12:42:40, haraken wrote: > On 2016/09/13 15:08:08, Torne wrote: > > > https://codereview.chromium.org/2309153002/diff/80001/content/renderer/render_thread_impl.cc ...
4 years, 3 months ago (2016-09-15 13:11:32 UTC) #29
haraken
On 2016/09/15 13:11:32, Torne wrote: > On 2016/09/15 12:42:40, haraken wrote: > > On 2016/09/13 ...
4 years, 3 months ago (2016-09-15 14:03:30 UTC) #30
Torne
On 2016/09/15 14:03:30, haraken wrote: > On 2016/09/15 13:11:32, Torne wrote: > > On 2016/09/15 ...
4 years, 3 months ago (2016-09-15 14:23:45 UTC) #31
Torne
On 2016/09/15 14:23:45, Torne wrote: > On 2016/09/15 14:03:30, haraken wrote: > > On 2016/09/15 ...
4 years, 3 months ago (2016-09-15 14:24:16 UTC) #32
haraken
On 2016/09/15 14:24:16, Torne wrote: > On 2016/09/15 14:23:45, Torne wrote: > > On 2016/09/15 ...
4 years, 3 months ago (2016-09-15 15:36:27 UTC) #33
Torne
On 2016/09/15 15:36:27, haraken wrote: > On 2016/09/15 14:24:16, Torne wrote: > > On 2016/09/15 ...
4 years, 3 months ago (2016-09-15 15:45:17 UTC) #34
haraken
jochen@, jam@, dcheng@, torne@: I'm working on removing a graceful shutdown sequence from the renderer ...
4 years, 2 months ago (2016-10-05 12:12:42 UTC) #57
Torne
On 2016/10/05 12:12:42, haraken wrote: > So, I'm now trying yet another approach in PS10: ...
4 years, 2 months ago (2016-10-05 15:05:00 UTC) #58
jam
On 2016/10/05 12:12:42, haraken wrote: > jochen@, jam@, dcheng@, torne@: > > I'm working on ...
4 years, 2 months ago (2016-10-05 17:50:03 UTC) #59
dcheng
On 2016/10/05 15:05:00, Torne wrote: > On 2016/10/05 12:12:42, haraken wrote: > > So, I'm ...
4 years, 2 months ago (2016-10-05 21:22:08 UTC) #60
haraken
jam@: On 2016/10/05 17:50:03, jam wrote: > On 2016/10/05 12:12:42, haraken wrote: > > jochen@, ...
4 years, 2 months ago (2016-10-06 01:34:39 UTC) #61
haraken
On 2016/10/05 21:22:08, dcheng wrote: > On 2016/10/05 15:05:00, Torne wrote: > > On 2016/10/05 ...
4 years, 2 months ago (2016-10-06 01:36:16 UTC) #62
Torne
On 2016/10/06 01:36:16, haraken wrote: > On 2016/10/05 21:22:08, dcheng wrote: > > On 2016/10/05 ...
4 years, 2 months ago (2016-10-06 11:05:34 UTC) #63
jam
Sorry I completely missed this reply till now. On 2016/10/06 01:34:39, haraken wrote: > jam@: ...
4 years, 2 months ago (2016-10-17 15:01:06 UTC) #86
haraken
On 2016/10/17 15:01:06, jam wrote: > Sorry I completely missed this reply till now. > ...
4 years, 2 months ago (2016-10-17 15:08:29 UTC) #87
jochen (gone - plz use gerrit)
(deferring to John)
4 years, 1 month ago (2016-10-26 08:29:57 UTC) #102
haraken
As a result of the attempt from PS13 - PS19, I've concluded that there're too ...
4 years, 1 month ago (2016-10-26 09:46:21 UTC) #103
jam
On 2016/10/17 15:08:29, haraken wrote: > On 2016/10/17 15:01:06, jam wrote: > > Sorry I ...
4 years, 1 month ago (2016-10-26 18:01:04 UTC) #104
haraken
On 2016/10/26 18:01:04, jam wrote: > On 2016/10/17 15:08:29, haraken wrote: > > On 2016/10/17 ...
4 years, 1 month ago (2016-10-26 18:28:17 UTC) #105
haraken
I think SingleProcessMemoryTracingTest is the only test running with the single process mode. We can ...
4 years, 1 month ago (2016-10-27 13:58:14 UTC) #110
haraken
On 2016/10/27 13:58:14, haraken wrote: > I think SingleProcessMemoryTracingTest is the only test running with ...
4 years, 1 month ago (2016-10-27 14:47:54 UTC) #111
Primiano Tucci (use gerrit)
On 2016/10/27 14:47:54, haraken wrote: > On 2016/10/27 13:58:14, haraken wrote: > > I think ...
4 years, 1 month ago (2016-10-27 15:41:10 UTC) #112
haraken
On 2016/10/27 15:41:10, Primiano Tucci wrote: > On 2016/10/27 14:47:54, haraken wrote: > > On ...
4 years, 1 month ago (2016-10-27 16:06:13 UTC) #113
jam
On 2016/10/26 18:28:17, haraken wrote: > On 2016/10/26 18:01:04, jam wrote: > > On 2016/10/17 ...
4 years, 1 month ago (2016-10-27 17:01:03 UTC) #114
haraken
On 2016/10/27 17:01:03, jam wrote: > On 2016/10/26 18:28:17, haraken wrote: > > On 2016/10/26 ...
4 years, 1 month ago (2016-10-27 20:29:36 UTC) #115
jam
On 2016/10/27 20:29:36, haraken wrote: > On 2016/10/27 17:01:03, jam wrote: > > On 2016/10/26 ...
4 years, 1 month ago (2016-10-28 19:15:52 UTC) #116
haraken
primiano@: As discussed in the chromium-dev test, would you mind rewriting the tracing test so ...
4 years, 1 month ago (2016-11-03 14:58:17 UTC) #117
Primiano Tucci (use gerrit)
On 2016/11/03 14:58:17, haraken wrote: > primiano@: As discussed in the chromium-dev test, would you ...
4 years, 1 month ago (2016-11-03 15:20:23 UTC) #118
haraken
(Sorry, I was busy with other stuff -- I'm now back on this CL.) torne@: ...
4 years ago (2016-12-02 02:20:23 UTC) #131
Torne
All these tests are single-process mode tests, as far as I can see: https://cs.chromium.org/search/?q=AppendSwitch%5C(switches::kSingleProcess&sq=package:chromium&type=cs So, ...
4 years ago (2016-12-05 12:23:45 UTC) #132
milijacob
Of course this tests are single process tests and this are tested on http://best-essay-writing-service-reviews.com/ of ...
4 years ago (2016-12-07 04:47:44 UTC) #149
haraken
torne@: Hmm, I still cannot pass single-process-mode tests on linux_android_rel :/ Patch set 32 is ...
4 years ago (2016-12-14 13:05:09 UTC) #167
Torne
On 2016/12/14 13:05:09, haraken wrote: > torne@: Hmm, I still cannot pass single-process-mode tests on ...
4 years ago (2016-12-14 13:22:27 UTC) #168
haraken
On 2016/12/14 13:22:27, Torne wrote: > On 2016/12/14 13:05:09, haraken wrote: > > torne@: Hmm, ...
4 years ago (2016-12-14 16:10:51 UTC) #169
Torne
On 2016/12/14 16:10:51, haraken wrote: > On 2016/12/14 13:22:27, Torne wrote: > > On 2016/12/14 ...
4 years ago (2016-12-14 16:17:36 UTC) #170
haraken
On 2016/12/14 16:17:36, Torne wrote: > On 2016/12/14 16:10:51, haraken wrote: > > On 2016/12/14 ...
4 years ago (2016-12-14 16:18:57 UTC) #171
haraken
torne@: See Patch Set 36. I moved _exit(0) to BrowserTestBase's destructor, but it is still ...
4 years ago (2016-12-16 10:22:56 UTC) #196
Torne
On 2016/12/16 10:22:56, haraken wrote: > torne@: See Patch Set 36. I moved _exit(0) to ...
4 years ago (2016-12-16 13:12:57 UTC) #197
haraken
Yaaaaaaaaaaaaaaaaaaaaaay!!! The patch set 59 finally passed all tests on all bots :D I'll write ...
3 years, 11 months ago (2017-01-10 14:20:51 UTC) #264
Torne
Had a quick look and this seems like a reasonable way to neuter this. Will ...
3 years, 11 months ago (2017-01-10 14:24:19 UTC) #265
haraken
torne@: PTAL overall jam@: PTAL at content/ dcheng@: PTAL at base/
3 years, 11 months ago (2017-01-11 08:25:08 UTC) #269
jochen (gone - plz use gerrit)
some questions https://codereview.chromium.org/2309153002/diff/1190001/content/child/child_process.cc File content/child/child_process.cc (right): https://codereview.chromium.org/2309153002/diff/1190001/content/child/child_process.cc#newcode74 content/child/child_process.cc:74: if (main_thread_->IsRenderThread()) { why not do this ...
3 years, 11 months ago (2017-01-11 12:26:26 UTC) #272
Torne
https://codereview.chromium.org/2309153002/diff/1190001/content/child/child_process.cc File content/child/child_process.cc (right): https://codereview.chromium.org/2309153002/diff/1190001/content/child/child_process.cc#newcode74 content/child/child_process.cc:74: if (main_thread_->IsRenderThread()) { On 2017/01/11 12:26:25, jochen wrote: > ...
3 years, 11 months ago (2017-01-11 12:50:58 UTC) #273
haraken
https://codereview.chromium.org/2309153002/diff/1190001/content/child/child_process.cc File content/child/child_process.cc (right): https://codereview.chromium.org/2309153002/diff/1190001/content/child/child_process.cc#newcode74 content/child/child_process.cc:74: if (main_thread_->IsRenderThread()) { On 2017/01/11 12:26:25, jochen wrote: > ...
3 years, 11 months ago (2017-01-11 12:52:25 UTC) #274
jochen (gone - plz use gerrit)
https://codereview.chromium.org/2309153002/diff/1190001/content/child/child_process.cc File content/child/child_process.cc (right): https://codereview.chromium.org/2309153002/diff/1190001/content/child/child_process.cc#newcode74 content/child/child_process.cc:74: if (main_thread_->IsRenderThread()) { On 2017/01/11 at 12:52:25, haraken wrote: ...
3 years, 11 months ago (2017-01-11 12:53:00 UTC) #275
haraken
On 2017/01/11 12:53:00, jochen wrote: > https://codereview.chromium.org/2309153002/diff/1190001/content/child/child_process.cc > File content/child/child_process.cc (right): > > https://codereview.chromium.org/2309153002/diff/1190001/content/child/child_process.cc#newcode74 > ...
3 years, 11 months ago (2017-01-11 12:54:36 UTC) #276
jochen (gone - plz use gerrit)
i find it conceptually nicer than having the ChildThread know about the renderer thread
3 years, 11 months ago (2017-01-11 13:01:28 UTC) #277
Torne
On 2017/01/11 13:01:28, jochen wrote: > i find it conceptually nicer than having the ChildThread ...
3 years, 11 months ago (2017-01-11 13:02:27 UTC) #278
jochen (gone - plz use gerrit)
On 2017/01/11 at 13:02:27, torne wrote: > On 2017/01/11 13:01:28, jochen wrote: > > i ...
3 years, 11 months ago (2017-01-11 13:07:16 UTC) #279
haraken
On 2017/01/11 13:07:16, jochen wrote: > On 2017/01/11 at 13:02:27, torne wrote: > > On ...
3 years, 11 months ago (2017-01-11 13:15:51 UTC) #280
haraken
On 2017/01/11 13:15:51, haraken wrote: > On 2017/01/11 13:07:16, jochen wrote: > > On 2017/01/11 ...
3 years, 11 months ago (2017-01-11 13:16:58 UTC) #281
Torne
On 2017/01/11 13:15:51, haraken wrote: > On 2017/01/11 13:07:16, jochen wrote: > > On 2017/01/11 ...
3 years, 11 months ago (2017-01-11 13:17:27 UTC) #282
haraken
On 2017/01/11 13:17:27, Torne wrote: > On 2017/01/11 13:15:51, haraken wrote: > > On 2017/01/11 ...
3 years, 11 months ago (2017-01-11 13:31:18 UTC) #283
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-11 13:32:51 UTC) #286
Torne
LGTM, thanks, this seems a bit cleaner :)
3 years, 11 months ago (2017-01-11 13:40:38 UTC) #287
dcheng
https://codereview.chromium.org/2309153002/diff/1230001/base/at_exit.cc File base/at_exit.cc (right): https://codereview.chromium.org/2309153002/diff/1230001/base/at_exit.cc#newcode85 base/at_exit.cc:85: if (!g_disable_managers) Is it important to pop the tasks ...
3 years, 11 months ago (2017-01-12 02:22:39 UTC) #290
haraken
https://codereview.chromium.org/2309153002/diff/1230001/base/at_exit.cc File base/at_exit.cc (right): https://codereview.chromium.org/2309153002/diff/1230001/base/at_exit.cc#newcode85 base/at_exit.cc:85: if (!g_disable_managers) On 2017/01/12 02:22:38, dcheng wrote: > Is ...
3 years, 11 months ago (2017-01-12 02:44:02 UTC) #291
dcheng
base LGTM with a nit https://codereview.chromium.org/2309153002/diff/1250001/base/at_exit.h File base/at_exit.h (right): https://codereview.chromium.org/2309153002/diff/1250001/base/at_exit.h#newcode53 base/at_exit.h:53: // process mode. See ...
3 years, 11 months ago (2017-01-12 04:16:34 UTC) #292
haraken
On 2017/01/12 04:16:34, dcheng wrote: > base LGTM with a nit > > https://codereview.chromium.org/2309153002/diff/1250001/base/at_exit.h > ...
3 years, 11 months ago (2017-01-12 04:27:41 UTC) #293
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309153002/1270001
3 years, 11 months ago (2017-01-12 04:28:59 UTC) #296
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/211772)
3 years, 11 months ago (2017-01-12 06:29:36 UTC) #298
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309153002/1270001
3 years, 11 months ago (2017-01-12 06:41:36 UTC) #300
commit-bot: I haz the power
Committed patchset #64 (id:1270001) as https://chromium.googlesource.com/chromium/src/+/bbfdd9f0669c9856883ffbf2cd9909e2a4df9dcf
3 years, 11 months ago (2017-01-12 07:14:45 UTC) #303
Primiano Tucci (use gerrit)
+brucedawson (see comment below) https://codereview.chromium.org/2309153002/diff/1270001/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/2309153002/diff/1270001/content/renderer/render_thread_impl.cc#newcode951 content/renderer/render_thread_impl.cc:951: _exit(0); You might want to ...
3 years, 11 months ago (2017-01-12 11:16:58 UTC) #305
Primiano Tucci (use gerrit)
Found the thread. See go/syuei and crbug.com/603131 . The api I was mentioning is TerminateProcess
3 years, 11 months ago (2017-01-12 11:18:34 UTC) #306
Torne
On 2017/01/12 11:18:34, Primiano Tucci (back but slow) wrote: > Found the thread. See go/syuei ...
3 years, 11 months ago (2017-01-12 11:22:46 UTC) #307
haraken
On 2017/01/12 11:22:46, Torne wrote: > On 2017/01/12 11:18:34, Primiano Tucci (back but slow) wrote: ...
3 years, 11 months ago (2017-01-12 11:25:31 UTC) #308
Primiano Tucci (use gerrit)
On 2017/01/12 11:25:31, haraken wrote: > On 2017/01/12 11:22:46, Torne wrote: > > On 2017/01/12 ...
3 years, 11 months ago (2017-01-12 11:58:03 UTC) #309
brucedawson
The odd behavior of _exit() on Windows - where it calls destructors - is for ...
3 years, 11 months ago (2017-01-12 18:19:55 UTC) #310
jenniferbauer143
3 years, 10 months ago (2017-02-21 12:24:04 UTC) #311
Message was sent while issue was closed.
This will make you feeling great with informative data. As you know the
jericoacoara rentals providing the excellent places for making your dream trip.
Visit more at http://www.jerihome.com/

Powered by Google App Engine
This is Rietveld 408576698