Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 23090004: Add comment about avoiding VS runtime support to OS::DebugBreak. (Closed)

Created:
7 years, 4 months ago by Benedikt Meurer
Modified:
7 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Add comment about avoiding VS runtime support to OS::DebugBreak. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/platform-win32.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Here you go :-)
7 years, 4 months ago (2013-08-23 11:50:10 UTC) #1
Michael Starzinger
LGTM. Thank you. :)
7 years, 4 months ago (2013-08-23 11:50:53 UTC) #2
Benedikt Meurer
7 years, 4 months ago (2013-08-23 11:51:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16294.

Powered by Google App Engine
This is Rietveld 408576698