Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: src/platform-win32.cc

Issue 23090004: Add comment about avoiding VS runtime support to OS::DebugBreak. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 992 matching lines...) Expand 10 before | Expand all | Expand 10 after
1003 DebugBreak(); 1003 DebugBreak();
1004 } else { 1004 } else {
1005 // Make the MSVCRT do a silent abort. 1005 // Make the MSVCRT do a silent abort.
1006 raise(SIGABRT); 1006 raise(SIGABRT);
1007 } 1007 }
1008 } 1008 }
1009 1009
1010 1010
1011 void OS::DebugBreak() { 1011 void OS::DebugBreak() {
1012 #ifdef _MSC_VER 1012 #ifdef _MSC_VER
1013 // To avoid Visual Studio runtime support the following code can be used
1014 // instead
1015 // __asm { int 3 }
1013 __debugbreak(); 1016 __debugbreak();
1014 #else 1017 #else
1015 ::DebugBreak(); 1018 ::DebugBreak();
1016 #endif 1019 #endif
1017 } 1020 }
1018 1021
1019 1022
1020 void OS::DumpBacktrace() { 1023 void OS::DumpBacktrace() {
1021 // Currently unsupported. 1024 // Currently unsupported.
1022 } 1025 }
(...skipping 967 matching lines...) Expand 10 before | Expand all | Expand 10 after
1990 limit_mutex = CreateMutex(); 1993 limit_mutex = CreateMutex();
1991 } 1994 }
1992 1995
1993 1996
1994 void OS::TearDown() { 1997 void OS::TearDown() {
1995 delete limit_mutex; 1998 delete limit_mutex;
1996 } 1999 }
1997 2000
1998 2001
1999 } } // namespace v8::internal 2002 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698