Set testonly to true for targets that depends on base_java_test_support

Set testonly to true for targets that depends on base_java_test_support

BUG=640116
Committed: https://crrev.com/37998d9dae51da52b1896aa9bd780b16600552c6
Cr-Commit-Position: refs/heads/master@{#417144}

[the real yoland, 2016-09-03 05:00:17]

yolandyan@chromium.org changed reviewers:
+ jbudorick@chromium.org, mikecase@chromium.org

[mikecase (-- gone --), 2016-09-06 17:44:30]

Link to BUG seems broken. Other than that, lgtm

[jbudorick, 2016-09-06 17:44:42]

Your bug ID is definitely wrong.

https://codereview.chromium.org/2308973002/diff/1/base/BUILD.gn
File base/BUILD.gn (right):

https://codereview.chromium.org/2308973002/diff/1/base/BUILD.gn#newcode2443
base/BUILD.gn:2443: android_library("base_java_unittest_support") {
This should be testonly.

https://codereview.chromium.org/2308973002/diff/1/components/invalidation/imp...
File components/invalidation/impl/BUILD.gn (right):

https://codereview.chromium.org/2308973002/diff/1/components/invalidation/imp...
components/invalidation/impl/BUILD.gn:228: android_library("javatests") {
I don't expect you to do anything here, but wow, the target names in this file
are woefully generic.

[the real yoland, 2016-09-06 19:52:47]

Description was changed from

==========
Set testonly to true for targets that depends on base_java_test_support

BUG=2273553002
==========

to

==========
Set testonly to true for targets that depends on base_java_test_support

BUG=640116
==========

[the real yoland, 2016-09-06 19:53:09]

https://codereview.chromium.org/2308973002/diff/1/base/BUILD.gn
File base/BUILD.gn (right):

https://codereview.chromium.org/2308973002/diff/1/base/BUILD.gn#newcode2443
base/BUILD.gn:2443: android_library("base_java_unittest_support") {
On 2016/09/06 at 17:44:42, jbudorick wrote:
> This should be testonly.

Done

https://codereview.chromium.org/2308973002/diff/1/components/invalidation/imp...
File components/invalidation/impl/BUILD.gn (right):

https://codereview.chromium.org/2308973002/diff/1/components/invalidation/imp...
components/invalidation/impl/BUILD.gn:228: android_library("javatests") {
On 2016/09/06 at 17:44:42, jbudorick wrote:
> I don't expect you to do anything here, but wow, the target names in this file
are woefully generic.

Time for git witch hunting?
Jk

[jbudorick, 2016-09-06 19:56:05]

lgtm

https://codereview.chromium.org/2308973002/diff/1/components/invalidation/imp...
File components/invalidation/impl/BUILD.gn (right):

https://codereview.chromium.org/2308973002/diff/1/components/invalidation/imp...
components/invalidation/impl/BUILD.gn:228: android_library("javatests") {
On 2016/09/06 19:53:09, the real yoland wrote:
> On 2016/09/06 at 17:44:42, jbudorick wrote:
> > I don't expect you to do anything here, but wow, the target names in this
file
> are woefully generic.
> 
> Time for git witch hunting?
> Jk

"Witch hunting" is definitely not something I'm interested in.

[the real yoland, 2016-09-06 19:57:12]

yolandyan@chromium.org changed reviewers:
+ nyquist@chromium.org, sclittle@chromium.org

[the real yoland, 2016-09-06 19:57:12]

add +nyquist for owner's lgtm on
    base/BUILD.gn
    components/invalidation/impl/BUILD.gn

add sclittle for owner's lgtm on
    components/precache/android/BUILD.gn

[sclittle, 2016-09-06 19:59:07]

components/precache/android/BUILD.gn LGTM

[nyquist, 2016-09-07 19:13:59]

//base, //components/invalidation/ lgtm

[the real yoland, 2016-09-07 23:02:03]

The CQ bit was checked by yolandyan@chromium.org

[the real yoland, 2016-09-07 23:02:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikecase@chromium.org
Link to the patchset: https://codereview.chromium.org/2308973002/#ps20001
(title: "Change according to comments")

[commit-bot: I haz the power, 2016-09-07 23:03:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 01:17:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-08 01:19:09]

Description was changed from

==========
Set testonly to true for targets that depends on base_java_test_support

BUG=640116
==========

to

==========
Set testonly to true for targets that depends on base_java_test_support

BUG=640116

Committed: https://crrev.com/37998d9dae51da52b1896aa9bd780b16600552c6
Cr-Commit-Position: refs/heads/master@{#417144}
==========

[commit-bot: I haz the power, 2016-09-08 01:19:11]

Patchset 2 (id:??) landed as
https://crrev.com/37998d9dae51da52b1896aa9bd780b16600552c6
Cr-Commit-Position: refs/heads/master@{#417144}