Set testonly to true for targets that depends on base_java_test_support

components/invalidation/impl/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 if (is_android) {
   import("//build/config/android/rules.gni")
 }
 
 static_library("impl") {
   sources = [
@@ skipping 207 matching lines @@
       "android/java/src/org/chromium/components/invalidation/InvalidationService.java",
       "android/java/src/org/chromium/components/invalidation/PendingInvalidation.java",
     ]
   }
   proto_java_library("proto_java") {
     proto_path = "android/proto"
     sources = [
       "$proto_path/serialized_invalidation.proto",
     ]
   }
   android_library("javatests") {

[jbudorick, 2016/09/06 17:44:42]

I don't expect you to do anything here, but wow, the target names in this file
are woefully generic.

[the real yoland, 2016/09/06 19:53:09]

Time for git witch hunting?
Jk

[jbudorick, 2016/09/06 19:56:05]

"Witch hunting" is definitely not something I'm interested in.

+    testonly = true
     deps = [
       ":java",
       "//base:base_java",
       "//base:base_java_test_support",
       "//components/sync/android:sync_java",
       "//third_party/cacheinvalidation:cacheinvalidation_javalib",
       "//third_party/cacheinvalidation:cacheinvalidation_proto_java",
     ]
     java_files = [
       "android/javatests/src/org/chromium/components/invalidation/InvalidationClientServiceTest.java",
       "android/javatests/src/org/chromium/components/invalidation/TestableInvalidationClientService.java",
     ]
   }
   junit_binary("components_invalidation_impl_junit_tests") {
     java_files = [ "android/junit/src/org/chromium/components/invalidation/PendingInvalidationTest.java" ]
     deps = [
       ":java",
       "//base:base_java",
       "//base:base_java_test_support",
     ]
   }
   generate_jni("jni_headers") {
     sources = [
       "android/java/src/org/chromium/components/invalidation/InvalidationService.java",
     ]
     jni_package = "components/invalidation"
   }
 }