Fix gn --check complaints about fxcrt. (try 2)

Fix gn --check complaints about fxcrt. (try 2)

Previous attempt: https://codereview.chromium.org/2289263005
It failed for the PDFium inside Chromium use case.
This time the paths are relative.

Committed: https://pdfium.googlesource.com/pdfium/+/73c485699b323eaecc801ce55460268f7a79b34e

[Lei Zhang, 2016-09-02 22:22:35]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 22:22:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-09-02 22:23:52]

Description was changed from

==========
Fix gn --check complaints about fxcrt. (try 2)
==========

to

==========
Fix gn --check complaints about fxcrt. (try 2)

Previous attempt failed for PDFium inside Chromium.
This time the paths are relative.
==========

[Lei Zhang, 2016-09-02 22:23:52]

thestig@chromium.org changed reviewers:
+ dpranke@chromium.org

[Lei Zhang, 2016-09-02 22:24:32]

Description was changed from

==========
Fix gn --check complaints about fxcrt. (try 2)

Previous attempt failed for PDFium inside Chromium.
This time the paths are relative.
==========

to

==========
Fix gn --check complaints about fxcrt. (try 2)

Previous attempt: https://codereview.chromium.org/2289263005
It failed for the PDFium inside Chromium usecase.
This time the paths are relative.
==========

[Lei Zhang, 2016-09-02 22:25:48]

Try try try again.

[Lei Zhang, 2016-09-02 22:26:02]

Description was changed from

==========
Fix gn --check complaints about fxcrt. (try 2)

Previous attempt: https://codereview.chromium.org/2289263005
It failed for the PDFium inside Chromium usecase.
This time the paths are relative.
==========

to

==========
Fix gn --check complaints about fxcrt. (try 2)

Previous attempt: https://codereview.chromium.org/2289263005
It failed for the PDFium inside Chromium use case.
This time the paths are relative.
==========

[commit-bot: I haz the power, 2016-09-02 22:36:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 22:36:18]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-09-06 00:57:10]

lgtm, with a couple of questions ...

https://codereview.chromium.org/2308873002/diff/20001/third_party/BUILD.gn
File third_party/BUILD.gn (right):

https://codereview.chromium.org/2308873002/diff/20001/third_party/BUILD.gn#ne...
third_party/BUILD.gn:7: import("../pdfium.gni")
These relative imports are unorthodox. Is this file imported during a
pdfium-in-chromium build?

If not, does "//pdfium.gni" work (and similarly for "//:fxcrt", below?

[Lei Zhang, 2016-09-06 19:22:59]

https://codereview.chromium.org/2308873002/diff/20001/third_party/BUILD.gn
File third_party/BUILD.gn (right):

https://codereview.chromium.org/2308873002/diff/20001/third_party/BUILD.gn#ne...
third_party/BUILD.gn:7: import("../pdfium.gni")
On 2016/09/06 00:57:09, Dirk Pranke wrote:
> These relative imports are unorthodox. Is this file imported during a
> pdfium-in-chromium build?
> 
> If not, does "//pdfium.gni" work (and similarly for "//:fxcrt", below?

Yes. PDFium uses many of its own third party libraries in a pdfium-in-chromium
build.

[Dirk Pranke, 2016-09-06 19:33:24]

On 2016/09/06 19:22:59, Lei Zhang wrote:
> https://codereview.chromium.org/2308873002/diff/20001/third_party/BUILD.gn
> File third_party/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2308873002/diff/20001/third_party/BUILD.gn#ne...
> third_party/BUILD.gn:7: import("../pdfium.gni")
> On 2016/09/06 00:57:09, Dirk Pranke wrote:
> > These relative imports are unorthodox. Is this file imported during a
> > pdfium-in-chromium build?
> > 
> > If not, does "//pdfium.gni" work (and similarly for "//:fxcrt", below?
> 
> Yes. PDFium uses many of its own third party libraries in a pdfium-in-chromium
> build.

Okay.

[Lei Zhang, 2016-09-06 20:45:02]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-09-06 20:45:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 21:07:20]

Description was changed from

==========
Fix gn --check complaints about fxcrt. (try 2)

Previous attempt: https://codereview.chromium.org/2289263005
It failed for the PDFium inside Chromium use case.
This time the paths are relative.
==========

to

==========
Fix gn --check complaints about fxcrt. (try 2)

Previous attempt: https://codereview.chromium.org/2289263005
It failed for the PDFium inside Chromium use case.
This time the paths are relative.

Committed:
https://pdfium.googlesource.com/pdfium/+/73c485699b323eaecc801ce55460268f7a79...
==========

[commit-bot: I haz the power, 2016-09-06 21:07:21]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/73c485699b323eaecc801ce55460268f7a79...