Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2289263005: Fix gn gn --check complaints about fxcrt. (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix gn gn --check complaints about fxcrt. Committed: https://pdfium.googlesource.com/pdfium/+/6f9ae19b9b125af868077f4eee80a13e0c29c61e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -31 lines) Patch
M BUILD.gn View 19 chunks +70 lines, -31 lines 0 comments Download
M third_party/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Lei Zhang
dpranke: Got any suggestions for simplifying this?
4 years, 3 months ago (2016-08-31 21:07:25 UTC) #2
Dirk Pranke
No, this looks about like what I'd expect. lgtm.
4 years, 3 months ago (2016-08-31 22:06:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289263005/1
4 years, 3 months ago (2016-08-31 23:01:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/6f9ae19b9b125af868077f4eee80a13e0c29c61e
4 years, 3 months ago (2016-08-31 23:01:45 UTC) #11
Lei Zhang
4 years, 3 months ago (2016-09-01 01:01:35 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2301783002/ by thestig@chromium.org.

The reason for reverting is: Breaking non-standalone builds..

Powered by Google App Engine
This is Rietveld 408576698