Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2308783002: Tell the kernel to discard USB requests when they time out. (Closed)

Created:
4 years, 3 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Tell the kernel to discard USB requests when they time out. This patch adds a call to USBDEVFS_DISCARDURB when we time out a USB transfer. This causes the host controller to stop polling the device for data and means that a later transfer will receive the next bytes that are sent from the device. Otherwise those bytes will be claimed by the cancelled transfer and discarded. BUG=640725 Review-Url: https://codereview.chromium.org/2274343002 Cr-Commit-Position: refs/heads/master@{#414635} (cherry picked from commit 6f91bd7e250f649c06e1059033943d56dbf0a79f) Committed: https://chromium.googlesource.com/chromium/src/+/6bc5ad0f6a48a2a136e5fe2510d83de6df8258ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -18 lines) Patch
M device/usb/usb_device_handle_usbfs.h View 1 chunk +4 lines, -2 lines 0 comments Download
M device/usb/usb_device_handle_usbfs.cc View 4 chunks +54 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Reilly Grant (use Gerrit)
4 years, 3 months ago (2016-09-02 19:48:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6bc5ad0f6a48a2a136e5fe2510d83de6df8258ef.

Powered by Google App Engine
This is Rietveld 408576698