Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2274343002: Tell the kernel to discard USB requests when they time out. (Closed)

Created:
4 years, 3 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 3 months ago
Reviewers:
juncai
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tell the kernel to discard USB requests when they time out. This patch adds a call to USBDEVFS_DISCARDURB when we time out a USB transfer. This causes the host controller to stop polling the device for data and means that a later transfer will receive the next bytes that are sent from the device. Otherwise those bytes will be claimed by the cancelled transfer and discarded. BUG=640725 Committed: https://crrev.com/6f91bd7e250f649c06e1059033943d56dbf0a79f Cr-Commit-Position: refs/heads/master@{#414635}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -17 lines) Patch
M device/usb/usb_device_handle_usbfs.h View 1 chunk +4 lines, -2 lines 0 comments Download
M device/usb/usb_device_handle_usbfs.cc View 4 chunks +53 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 3 months ago (2016-08-25 00:29:01 UTC) #3
juncai
LGTM.
4 years, 3 months ago (2016-08-26 01:08:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274343002/1
4 years, 3 months ago (2016-08-26 01:23:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 02:42:21 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 02:45:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f91bd7e250f649c06e1059033943d56dbf0a79f
Cr-Commit-Position: refs/heads/master@{#414635}

Powered by Google App Engine
This is Rietveld 408576698