Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1580)

Unified Diff: third_party/crashpad/crashpad/client/crashpad_client.h

Issue 2308763002: Integrate Crashpad UMA (Closed)
Patch Set: pass through user data dir for metrics Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/client/crashpad_client.h
diff --git a/third_party/crashpad/crashpad/client/crashpad_client.h b/third_party/crashpad/crashpad/client/crashpad_client.h
index 61338a3c5f72a30a0702cfe05dcaff53e10ed768..31b37a84a19daf93a0205021e8b06de0cb222bc1 100644
--- a/third_party/crashpad/crashpad/client/crashpad_client.h
+++ b/third_party/crashpad/crashpad/client/crashpad_client.h
@@ -55,6 +55,9 @@ class CrashpadClient {
//! \param[in] handler The path to a Crashpad handler executable.
//! \param[in] database The path to a Crashpad database. The handler will be
//! started with this path as its `--database` argument.
+ //! \param[in] metrics The path to an already existing directory where metrics
+ //! files can be stored. The handler will be started with this path as its
+ //! `--metrics` argument.
//! \param[in] url The URL of an upload server. The handler will be started
//! with this URL as its `--url` argument.
//! \param[in] annotations Process annotations to set in each crash report.
@@ -72,6 +75,7 @@ class CrashpadClient {
//! \return `true` on success, `false` on failure with a message logged.
bool StartHandler(const base::FilePath& handler,
const base::FilePath& database,
+ const base::FilePath& metrics,
const std::string& url,
const std::map<std::string, std::string>& annotations,
const std::vector<std::string>& arguments,

Powered by Google App Engine
This is Rietveld 408576698