Integrate Crashpad UMA

components/crash/content/app/crash_reporter_client.h

Index: components/crash/content/app/crash_reporter_client.h
diff --git a/components/crash/content/app/crash_reporter_client.h b/components/crash/content/app/crash_reporter_client.h
index 70f089cf9dfe93fc527f5bf565a6bc890157d32d..545af4d0d86185ce15fca6c9fe3fe6db2eb79474 100644
--- a/components/crash/content/app/crash_reporter_client.h
+++ b/components/crash/content/app/crash_reporter_client.h
@@ -128,6 +128,14 @@ class CrashReporterClient {
   virtual bool GetCrashDumpLocation(base::FilePath* crash_dir);
 #endif
 
+  // The location where metrics files should be written. Returns true if
+  // |metrics_dir| was set.
+#if defined(OS_WIN)

[bcwhite, 2016/09/14 13:16:12]

Why can't Windows use FilePath?

[scottmg, 2016/09/14 20:37:02]

(This is copied from GetCrashDumpLocation() above.) base::FilePath uses a lot of
base (e.g. logging and so on) which in turn pulls in a variety of Windows DLLs.
This code is used in chrome_elf.dll where kernel32.dll is the only allowed
dependency.

[bcwhite, 2016/09/14 21:11:29]

Makes sense.  Add to comment?

[scottmg, 2016/09/14 22:12:30]

Done.

+  virtual bool GetCrashMetricsLocation(base::string16* metrics_dir);
+#else
+  virtual bool GetCrashMetricsLocation(base::FilePath* metrics_dir);
+#endif
+
   // Register all of the potential crash keys that can be sent to the crash
   // reporting server. Returns the size of the union of all keys.
   virtual size_t RegisterCrashKeys();