Integrate Crashpad UMA

components/crash/content/app/crash_reporter_client.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_CRASH_CONTENT_APP_CRASH_REPORTER_CLIENT_H_
 #define COMPONENTS_CRASH_CONTENT_APP_CRASH_REPORTER_CLIENT_H_
 
 #include <stddef.h>
 
 #include <string>
@@ skipping 110 matching lines @@
 #endif
 
   // The location where minidump files should be written. Returns true if
   // |crash_dir| was set.
 #if defined(OS_WIN)
   virtual bool GetCrashDumpLocation(base::string16* crash_dir);
 #else
   virtual bool GetCrashDumpLocation(base::FilePath* crash_dir);
 #endif
 
+  // The location where metrics files should be written. Returns true if
+  // |metrics_dir| was set.
+#if defined(OS_WIN)

[bcwhite, 2016/09/14 13:16:12]

Why can't Windows use FilePath?

[scottmg, 2016/09/14 20:37:02]

(This is copied from GetCrashDumpLocation() above.) base::FilePath uses a lot of
base (e.g. logging and so on) which in turn pulls in a variety of Windows DLLs.
This code is used in chrome_elf.dll where kernel32.dll is the only allowed
dependency.

[bcwhite, 2016/09/14 21:11:29]

Makes sense.  Add to comment?

[scottmg, 2016/09/14 22:12:30]

Done.

+  virtual bool GetCrashMetricsLocation(base::string16* metrics_dir);
+#else
+  virtual bool GetCrashMetricsLocation(base::FilePath* metrics_dir);
+#endif
+
   // Register all of the potential crash keys that can be sent to the crash
   // reporting server. Returns the size of the union of all keys.
   virtual size_t RegisterCrashKeys();
 
   // Returns true if running in unattended mode (for automated testing).
   virtual bool IsRunningUnattended();
 
   // Returns true if the user has given consent to collect stats.
   virtual bool GetCollectStatsConsent();
 
@@ skipping 21 matching lines @@
   virtual bool ShouldEnableBreakpadMicrodumps();
 #endif
 
   // Returns true if breakpad should run in the given process type.
   virtual bool EnableBreakpadForProcess(const std::string& process_type);
 };
 
 }  // namespace crash_reporter
 
 #endif  // COMPONENTS_CRASH_CONTENT_APP_CRASH_REPORTER_CLIENT_H_