Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2308733002: remove unused SkDevice::setMatrixClip (Closed)

Created:
4 years, 3 months ago by reed1
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -24 lines) Patch
M include/core/SkDevice.h View 1 chunk +0 lines, -19 lines 0 comments Download
M src/core/SkCanvas.cpp View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
reed1
see no callers/overrides in chrome or android
4 years, 3 months ago (2016-09-02 18:43:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2308733002/1
4 years, 3 months ago (2016-09-02 18:43:38 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-02 18:43:39 UTC) #6
tomhudson
If the bots like it, LGTM. (Previous Chrome cleanup here was https://bugs.chromium.org/p/chromium/issues/detail?id=609894)
4 years, 3 months ago (2016-09-02 18:49:25 UTC) #7
bsalomon
lgtm
4 years, 3 months ago (2016-09-02 18:53:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/de6c531e468197bb7746f1217a8ccb2ab175e0b8
4 years, 3 months ago (2016-09-02 19:10:10 UTC) #10
mariadominice
4 years, 3 months ago (2016-09-09 17:31:46 UTC) #11
mariadominice
4 years, 3 months ago (2016-09-09 17:32:02 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698