Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 2308653002: Turn on trace shutdown flag on Windows (Closed)

Created:
4 years, 3 months ago by zra
Modified:
4 years, 3 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Turn on trace shutdown flag on Windows There are flaky crashes on the Windows bots that look like they are happening during shutdown. Temporarily turn on the trace shutdown flag to help investigate. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/d640f6ae490dd7fcc06d33e792666a3223efc7c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/vm/dart.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 3 months ago (2016-09-02 17:09:10 UTC) #2
siva
lgtm
4 years, 3 months ago (2016-09-02 17:10:24 UTC) #3
zra
4 years, 3 months ago (2016-09-02 17:12:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d640f6ae490dd7fcc06d33e792666a3223efc7c2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698