Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Side by Side Diff: runtime/vm/dart.cc

Issue 2308653002: Turn on trace shutdown flag on Windows (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/dart.h" 5 #include "vm/dart.h"
6 6
7 #include "vm/become.h" 7 #include "vm/become.h"
8 #include "vm/clustered_snapshot.h" 8 #include "vm/clustered_snapshot.h"
9 #include "vm/code_observers.h" 9 #include "vm/code_observers.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 23 matching lines...) Expand all
34 #include "vm/timeline.h" 34 #include "vm/timeline.h"
35 #include "vm/virtual_memory.h" 35 #include "vm/virtual_memory.h"
36 #include "vm/zone.h" 36 #include "vm/zone.h"
37 37
38 namespace dart { 38 namespace dart {
39 39
40 DECLARE_FLAG(bool, print_class_table); 40 DECLARE_FLAG(bool, print_class_table);
41 DECLARE_FLAG(bool, trace_time_all); 41 DECLARE_FLAG(bool, trace_time_all);
42 DEFINE_FLAG(bool, keep_code, false, 42 DEFINE_FLAG(bool, keep_code, false,
43 "Keep deoptimized code for profiling."); 43 "Keep deoptimized code for profiling.");
44 #if defined(TARGET_OS_WINDOWS)
45 DEFINE_FLAG(bool, trace_shutdown, true, "Trace VM shutdown on stderr");
46 #else
44 DEFINE_FLAG(bool, trace_shutdown, false, "Trace VM shutdown on stderr"); 47 DEFINE_FLAG(bool, trace_shutdown, false, "Trace VM shutdown on stderr");
48 #endif // defined(TARGET_OS_WINDOWS)
45 49
46 Isolate* Dart::vm_isolate_ = NULL; 50 Isolate* Dart::vm_isolate_ = NULL;
47 int64_t Dart::start_time_ = 0; 51 int64_t Dart::start_time_ = 0;
48 ThreadPool* Dart::thread_pool_ = NULL; 52 ThreadPool* Dart::thread_pool_ = NULL;
49 DebugInfo* Dart::pprof_symbol_generator_ = NULL; 53 DebugInfo* Dart::pprof_symbol_generator_ = NULL;
50 ReadOnlyHandles* Dart::predefined_handles_ = NULL; 54 ReadOnlyHandles* Dart::predefined_handles_ = NULL;
51 Snapshot::Kind Dart::snapshot_kind_ = Snapshot::kInvalid; 55 Snapshot::Kind Dart::snapshot_kind_ = Snapshot::kInvalid;
52 const uint8_t* Dart::instructions_snapshot_buffer_ = NULL; 56 const uint8_t* Dart::instructions_snapshot_buffer_ = NULL;
53 const uint8_t* Dart::data_snapshot_buffer_ = NULL; 57 const uint8_t* Dart::data_snapshot_buffer_ = NULL;
54 Dart_ThreadExitCallback Dart::thread_exit_callback_ = NULL; 58 Dart_ThreadExitCallback Dart::thread_exit_callback_ = NULL;
(...skipping 668 matching lines...) Expand 10 before | Expand all | Expand 10 after
723 return predefined_handles_->handles_.IsValidScopedHandle(address); 727 return predefined_handles_->handles_.IsValidScopedHandle(address);
724 } 728 }
725 729
726 730
727 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) { 731 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) {
728 ASSERT(predefined_handles_ != NULL); 732 ASSERT(predefined_handles_ != NULL);
729 return predefined_handles_->api_handles_.IsValidHandle(handle); 733 return predefined_handles_->api_handles_.IsValidHandle(handle);
730 } 734 }
731 735
732 } // namespace dart 736 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698