ui/PRESUBMIT.py: Recommend MakeUnique() before WrapUnique()

ui/PRESUBMIT.py: Recommend MakeUnique() before WrapUnique()

MakeUnique() is preferred to WrapUnique() in most cases. See
chromium-dev thread at

https://groups.google.com/a/chromium.org/d/msg/chromium-dev/iQgMedVA8-k/u7HSaY4KCwAJ

Modify the presubmit to recommend MakeUnique<T>() before WrapUnique() when it encounters the unique_ptr constructor used in an
rvalue context.

MakeUnique() cannot be used in every case
where WrapUnique() can, so continue to mention WrapUnique().

R=sky
BUG=

Committed: https://crrev.com/4376826e1edeb5f8c64df649aa2f0c0bb4597f21
Cr-Commit-Position: refs/heads/master@{#416830}

[Adam Rice, 2016-09-02 06:28:02]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 06:28:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 07:10:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 07:10:25]

Dry run: This issue passed the CQ dry run.

[sky, 2016-09-02 14:17:44]

https://codereview.chromium.org/2308473002/diff/1/ui/PRESUBMIT.py
File ui/PRESUBMIT.py (right):

https://codereview.chromium.org/2308473002/diff/1/ui/PRESUBMIT.py#newcode34
ui/PRESUBMIT.py:34: 'Use base::MakeUnique<T>() instead.') %
This wording is not correct as it implies MakeUnique always work, but that isn't
the case.

[Adam Rice, 2016-09-05 06:46:05]

https://codereview.chromium.org/2308473002/diff/1/ui/PRESUBMIT.py
File ui/PRESUBMIT.py (right):

https://codereview.chromium.org/2308473002/diff/1/ui/PRESUBMIT.py#newcode34
ui/PRESUBMIT.py:34: 'Use base::MakeUnique<T>() instead.') %
On 2016/09/02 14:17:44, sky wrote:
> This wording is not correct as it implies MakeUnique always work, but that
isn't
> the case.

Fixed.

[sky, 2016-09-06 18:17:42]

LGTM

[Adam Rice, 2016-09-07 02:15:48]

Description was changed from

==========
ui/PRESUBMIT.py: Recommend MakeUnique() rather than WrapUnique()

MakeUnique() is preferred to WrapUnique() in most cases. See
chromium-dev thread at

https://groups.google.com/a/chromium.org/d/msg/chromium-dev/iQgMedVA8-k/u7HSa...

Modify the presubmit to recommend MakeUnique<T>() rather than
WrapUnique() when it encounters the unique_ptr constructor used in an
rvalue context.

This is overly simplistic as MakeUnique() cannot be used in every case
where WrapUnique() can, but it should point people in the right
direction.

R=sky
BUG=
==========

to

==========
ui/PRESUBMIT.py: Recommend MakeUnique() before WrapUnique()

MakeUnique() is preferred to WrapUnique() in most cases. See
chromium-dev thread at

https://groups.google.com/a/chromium.org/d/msg/chromium-dev/iQgMedVA8-k/u7HSa...

Modify the presubmit to recommend MakeUnique<T>() before WrapUnique() when it
encounters the unique_ptr constructor used in an
rvalue context.

MakeUnique() cannot be used in every case
where WrapUnique() can, so continue to mention WrapUnique().

R=sky
BUG=
==========

[Adam Rice, 2016-09-07 02:15:52]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2016-09-07 02:16:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 03:03:17]

Description was changed from

==========
ui/PRESUBMIT.py: Recommend MakeUnique() before WrapUnique()

MakeUnique() is preferred to WrapUnique() in most cases. See
chromium-dev thread at

https://groups.google.com/a/chromium.org/d/msg/chromium-dev/iQgMedVA8-k/u7HSa...

Modify the presubmit to recommend MakeUnique<T>() before WrapUnique() when it
encounters the unique_ptr constructor used in an
rvalue context.

MakeUnique() cannot be used in every case
where WrapUnique() can, so continue to mention WrapUnique().

R=sky
BUG=
==========

to

==========
ui/PRESUBMIT.py: Recommend MakeUnique() before WrapUnique()

MakeUnique() is preferred to WrapUnique() in most cases. See
chromium-dev thread at

https://groups.google.com/a/chromium.org/d/msg/chromium-dev/iQgMedVA8-k/u7HSa...

Modify the presubmit to recommend MakeUnique<T>() before WrapUnique() when it
encounters the unique_ptr constructor used in an
rvalue context.

MakeUnique() cannot be used in every case
where WrapUnique() can, so continue to mention WrapUnique().

R=sky
BUG=
==========

[commit-bot: I haz the power, 2016-09-07 03:03:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-07 03:04:44]

Description was changed from

==========
ui/PRESUBMIT.py: Recommend MakeUnique() before WrapUnique()

MakeUnique() is preferred to WrapUnique() in most cases. See
chromium-dev thread at

https://groups.google.com/a/chromium.org/d/msg/chromium-dev/iQgMedVA8-k/u7HSa...

Modify the presubmit to recommend MakeUnique<T>() before WrapUnique() when it
encounters the unique_ptr constructor used in an
rvalue context.

MakeUnique() cannot be used in every case
where WrapUnique() can, so continue to mention WrapUnique().

R=sky
BUG=
==========

to

==========
ui/PRESUBMIT.py: Recommend MakeUnique() before WrapUnique()

MakeUnique() is preferred to WrapUnique() in most cases. See
chromium-dev thread at

https://groups.google.com/a/chromium.org/d/msg/chromium-dev/iQgMedVA8-k/u7HSa...

Modify the presubmit to recommend MakeUnique<T>() before WrapUnique() when it
encounters the unique_ptr constructor used in an
rvalue context.

MakeUnique() cannot be used in every case
where WrapUnique() can, so continue to mention WrapUnique().

R=sky
BUG=

Committed: https://crrev.com/4376826e1edeb5f8c64df649aa2f0c0bb4597f21
Cr-Commit-Position: refs/heads/master@{#416830}
==========

[commit-bot: I haz the power, 2016-09-07 03:04:45]

Patchset 2 (id:??) landed as
https://crrev.com/4376826e1edeb5f8c64df649aa2f0c0bb4597f21
Cr-Commit-Position: refs/heads/master@{#416830}