ui/PRESUBMIT.py - Issue 2308473002: ui/PRESUBMIT.py: Recommend MakeUnique() before WrapUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/PRESUBMIT.py

Issue 2308473002: ui/PRESUBMIT.py: Recommend MakeUnique() before WrapUnique() (Closed)

Patch Set: Mention WrapUnique as well as MakeUnique Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/PRESUBMIT.py

diff --git a/ui/PRESUBMIT.py b/ui/PRESUBMIT.py

index 482299dda2fc92123ffb5e9c3fa2e8240b2efb7f..4ee1ec87e3a7a8e181fea6606c602131c63c68ef 100644

--- a/ui/PRESUBMIT.py

+++ b/ui/PRESUBMIT.py

@@ -31,7 +31,8 @@ def CheckUniquePtr(input_api, output_api,

r'(=|\breturn)\s*std::unique_ptr<[^\[\]>]+>\([^)]+\)', line):

errors.append(output_api.PresubmitError(

('%s:%d uses explicit std::unique_ptr constructor. ' +

- 'Use base::WrapUnique() instead.') % (f.LocalPath(), line_number)))

+ 'Use base::MakeUnique<T>() or base::WrapUnique() instead.') %

+ (f.LocalPath(), line_number)))

# TODO(sky): this incorrectly catches templates. Fix and reenable.

# Disallow:

# std::unique_ptr<T>()

« no previous file with comments | « no previous file | no next file » | no next file with comments »