Chromium Code Reviews
DescriptionRefer internal PIEX library by using <include> tag in piex.pexe.txt.
We put PIEX internal library in ui/file_manager/internal directory. The
problem is we cannot access the resources in the directory by using
chrome-extension:// URL because it's not under extension directory.
Previously we prepared the dummy file of PIEX file in image_loader
extension, and assigns the same resource ID both to the dummy file and
internal library. It enabled the image loader extension to access
internal library via the URL of dummy file.
The CL removes the hack and adds <include> tag to the dummy file. The
contents of dummy file is replaced with the internal library by
<include> tag at the compile time.
BUG=642924
TEST=load raw file with official chrome
Review-Url: https://codereview.chromium.org/2300283002
Cr-Commit-Position: refs/heads/master@{#416358}
(cherry picked from commit 55e10010b0e3c851165f7b8af4465d05d525d729)
Committed: https://chromium.googlesource.com/chromium/src/+/d0d8bece245e83fd7e9af27020f4f86f614cc391
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||