Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1335)

Issue 2300283002: Refer internal PIEX library by using <include> tag in piex.pexe.txt. (Closed)

Created:
4 years, 3 months ago by hirono
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refer internal PIEX library by using <include> tag in piex.pexe.txt. We put PIEX internal library in ui/file_manager/internal directory. The problem is we cannot access the resources in the directory by using chrome-extension:// URL because it's not under extension directory. Previously we prepared the dummy file of PIEX file in image_loader extension, and assigns the same resource ID both to the dummy file and internal library. It enabled the image loader extension to access internal library via the URL of dummy file. The CL removes the hack and adds <include> tag to the dummy file. The contents of dummy file is replaced with the internal library by <include> tag at the compile time. BUG=642924 TEST=load raw file with official chrome Committed: https://crrev.com/55e10010b0e3c851165f7b8af4465d05d525d729 Cr-Commit-Position: refs/heads/master@{#416358}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M ui/file_manager/file_manager_resources.grd View 1 chunk +3 lines, -6 lines 0 comments Download
M ui/file_manager/image_loader/piex/piex.pexe.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
hirono
PTAL, thank you!
4 years, 3 months ago (2016-09-02 05:13:33 UTC) #2
fukino
LGTM. Thank you for the fix.
4 years, 3 months ago (2016-09-02 05:22:01 UTC) #3
hirono
On 2016/09/02 05:22:01, fukino wrote: > LGTM. Thank you for the fix. Thank you for ...
4 years, 3 months ago (2016-09-02 05:23:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300283002/1
4 years, 3 months ago (2016-09-02 05:23:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/257062) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 3 months ago (2016-09-02 05:27:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300283002/1
4 years, 3 months ago (2016-09-02 21:13:59 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 21:59:51 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 22:03:40 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55e10010b0e3c851165f7b8af4465d05d525d729
Cr-Commit-Position: refs/heads/master@{#416358}

Powered by Google App Engine
This is Rietveld 408576698