Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: chrome/common/BUILD.gn

Issue 2308313003: gn: Generalize process_version() and move it to build/util (Closed)
Patch Set: Move branding_file_path to chrome/process_version_rc_template.gni Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_watcher/BUILD.gn ('k') | chrome/installer/gcapi/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index 4f7b215d4e345b86868aca9322332613cab314e7..69d0d9f49caf34e694d77ba7e1ff4d35eda18856 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -3,8 +3,9 @@
# found in the LICENSE file.
import("//build/buildflag_header.gni")
+import("//build/util/process_version.gni")
import("//chrome/common/features.gni")
-import("//chrome/version.gni")
+import("//chrome/process_version_rc_template.gni") # For branding_file_path.
import("//mojo/public/tools/bindings/mojom.gni")
import("//tools/grit/grit_rule.gni")
@@ -509,8 +510,11 @@ process_version("version_header") {
# currently depends on this.
#visibility = [ ":*" ]
- # This one just uses the custom template and no separate sources.
- sources = []
+ sources = [
+ "//build/util/LASTCHANGE",
+ "//chrome/VERSION",
+ branding_file_path,
+ ]
template_file = "chrome_version.h.in"
output = "$target_gen_dir/chrome_version.h"
« no previous file with comments | « chrome/chrome_watcher/BUILD.gn ('k') | chrome/installer/gcapi/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698