Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: chrome/common/BUILD.gn

Issue 2308313003: gn: Generalize process_version() and move it to build/util (Closed)
Patch Set: Move branding_file_path to chrome/process_version_rc_template.gni Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/chrome_watcher/BUILD.gn ('k') | chrome/installer/gcapi/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/util/process_version.gni")
6 import("//chrome/common/features.gni") 7 import("//chrome/common/features.gni")
7 import("//chrome/version.gni") 8 import("//chrome/process_version_rc_template.gni") # For branding_file_path.
8 import("//mojo/public/tools/bindings/mojom.gni") 9 import("//mojo/public/tools/bindings/mojom.gni")
9 import("//tools/grit/grit_rule.gni") 10 import("//tools/grit/grit_rule.gni")
10 11
11 grit("resources") { 12 grit("resources") {
12 source = "common_resources.grd" 13 source = "common_resources.grd"
13 use_qualified_include = true 14 use_qualified_include = true
14 output_dir = "$root_gen_dir/chrome" 15 output_dir = "$root_gen_dir/chrome"
15 output_name = "common_resources" 16 output_name = "common_resources"
16 outputs = [ 17 outputs = [
17 "grit/common_resources.h", 18 "grit/common_resources.h",
(...skipping 484 matching lines...) Expand 10 before | Expand all | Expand 10 after
502 ] 503 ]
503 } 504 }
504 } 505 }
505 } 506 }
506 507
507 process_version("version_header") { 508 process_version("version_header") {
508 # TODO(brettw) this should have more reduced visibility, but chrome/browser 509 # TODO(brettw) this should have more reduced visibility, but chrome/browser
509 # currently depends on this. 510 # currently depends on this.
510 #visibility = [ ":*" ] 511 #visibility = [ ":*" ]
511 512
512 # This one just uses the custom template and no separate sources. 513 sources = [
513 sources = [] 514 "//build/util/LASTCHANGE",
515 "//chrome/VERSION",
516 branding_file_path,
517 ]
514 template_file = "chrome_version.h.in" 518 template_file = "chrome_version.h.in"
515 519
516 output = "$target_gen_dir/chrome_version.h" 520 output = "$target_gen_dir/chrome_version.h"
517 } 521 }
518 522
519 static_library("constants") { 523 static_library("constants") {
520 sources = [ 524 sources = [
521 "chrome_constants.cc", 525 "chrome_constants.cc",
522 "chrome_constants.h", 526 "chrome_constants.h",
523 "chrome_features.cc", 527 "chrome_features.cc",
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
641 "resource_usage_reporter.mojom", 645 "resource_usage_reporter.mojom",
642 "shell_handler_win.mojom", 646 "shell_handler_win.mojom",
643 ] 647 ]
644 648
645 public_deps = [ 649 public_deps = [
646 "//skia/public/interfaces", 650 "//skia/public/interfaces",
647 ] 651 ]
648 652
649 use_new_wrapper_types = false 653 use_new_wrapper_types = false
650 } 654 }
OLDNEW
« no previous file with comments | « chrome/chrome_watcher/BUILD.gn ('k') | chrome/installer/gcapi/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698