Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3265)

Unified Diff: chrome/app/version_assembly/BUILD.gn

Issue 2308313003: gn: Generalize process_version() and move it to build/util (Closed)
Patch Set: Move branding_file_path to chrome/process_version_rc_template.gni Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/BUILD.gn ('k') | chrome/chrome_watcher/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/version_assembly/BUILD.gn
diff --git a/chrome/app/version_assembly/BUILD.gn b/chrome/app/version_assembly/BUILD.gn
index 5e38ca978bb395b66fe750e5f60f5e2983c9503e..f9336e7c6803e5d4989527f48276ab2d1f7c6a0a 100644
--- a/chrome/app/version_assembly/BUILD.gn
+++ b/chrome/app/version_assembly/BUILD.gn
@@ -3,8 +3,8 @@
# found in the LICENSE file.
import("//build/config/win/manifest.gni")
+import("//build/util/process_version.gni")
import("//build/util/version.gni")
-import("//chrome/version.gni")
version_assembly_output_file = "$target_gen_dir/version_assembly.manifest"
@@ -12,6 +12,9 @@ version_assembly_output_file = "$target_gen_dir/version_assembly.manifest"
process_version("chrome_exe_version_manifest") {
visibility = [ ":*" ]
template_file = "chrome_exe_manifest.template"
+ sources = [
+ "//chrome/VERSION",
+ ]
output = version_assembly_output_file
}
@@ -36,6 +39,9 @@ windows_manifest("chrome_exe_manifest") {
# directory where Chrome finds chrome.dll.
process_version("version_assembly_manifest") {
template_file = "version_assembly_manifest.template"
+ sources = [
+ "//chrome/VERSION",
+ ]
output = "$root_build_dir/$chrome_version_full.manifest"
process_only = true
}
« no previous file with comments | « chrome/android/BUILD.gn ('k') | chrome/chrome_watcher/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698