Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Side by Side Diff: chrome/app/version_assembly/BUILD.gn

Issue 2308313003: gn: Generalize process_version() and move it to build/util (Closed)
Patch Set: Move branding_file_path to chrome/process_version_rc_template.gni Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/BUILD.gn ('k') | chrome/chrome_watcher/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/win/manifest.gni") 5 import("//build/config/win/manifest.gni")
6 import("//build/util/process_version.gni")
6 import("//build/util/version.gni") 7 import("//build/util/version.gni")
7 import("//chrome/version.gni")
8 8
9 version_assembly_output_file = "$target_gen_dir/version_assembly.manifest" 9 version_assembly_output_file = "$target_gen_dir/version_assembly.manifest"
10 10
11 # Generates a manifest file with the current build's version information. 11 # Generates a manifest file with the current build's version information.
12 process_version("chrome_exe_version_manifest") { 12 process_version("chrome_exe_version_manifest") {
13 visibility = [ ":*" ] 13 visibility = [ ":*" ]
14 template_file = "chrome_exe_manifest.template" 14 template_file = "chrome_exe_manifest.template"
15 sources = [
16 "//chrome/VERSION",
17 ]
15 output = version_assembly_output_file 18 output = version_assembly_output_file
16 } 19 }
17 20
18 # Generates the manifest for chrome.exe. This is the normal manifest stuff plus 21 # Generates the manifest for chrome.exe. This is the normal manifest stuff plus
19 # the version information. 22 # the version information.
20 windows_manifest("chrome_exe_manifest") { 23 windows_manifest("chrome_exe_manifest") {
21 sources = [ 24 sources = [
22 as_invoker_manifest, 25 as_invoker_manifest,
23 common_controls_manifest, 26 common_controls_manifest,
24 default_compatibility_manifest, 27 default_compatibility_manifest,
25 version_assembly_output_file, 28 version_assembly_output_file,
26 ] 29 ]
27 30
28 type = "exe" 31 type = "exe"
29 32
30 deps = [ 33 deps = [
31 ":chrome_exe_version_manifest", 34 ":chrome_exe_version_manifest",
32 ] 35 ]
33 } 36 }
34 37
35 # Generates the manifest for the version assembly, which is the versioned 38 # Generates the manifest for the version assembly, which is the versioned
36 # directory where Chrome finds chrome.dll. 39 # directory where Chrome finds chrome.dll.
37 process_version("version_assembly_manifest") { 40 process_version("version_assembly_manifest") {
38 template_file = "version_assembly_manifest.template" 41 template_file = "version_assembly_manifest.template"
42 sources = [
43 "//chrome/VERSION",
44 ]
39 output = "$root_build_dir/$chrome_version_full.manifest" 45 output = "$root_build_dir/$chrome_version_full.manifest"
40 process_only = true 46 process_only = true
41 } 47 }
OLDNEW
« no previous file with comments | « chrome/android/BUILD.gn ('k') | chrome/chrome_watcher/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698