recipe_modules/bot_update/example.expected/basic.json - Issue 2308193002: Remove bogus master/builder/slave/force parameters from bot_update.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: recipe_modules/bot_update/example.expected/basic.json

Issue 2308193002: Remove bogus master/builder/slave/force parameters from bot_update. (Closed)

Patch Set: re-do patch after recent CLs Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « recipe_modules/bot_update/example.py ('k') | recipe_modules/bot_update/example.expected/basic_output_manifest.json » ('j') | recipe_modules/bot_update/resources/bot_update.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",

8 "chromium.linux",

9 "--builder",

10 "Linux Builder",

11 "--slave",

12 "totallyaslave-m1",

13 "--spec",	7 "--spec",

14 "cache_dir = '[GIT_CACHE]'\nsolutions = [{'deps_file': '.DEPS.git', 'manag ed': True, 'name': 'src', 'url': 'https://chromium.googlesource.com/chromium/src .git'}]",	8 "cache_dir = '[GIT_CACHE]'\nsolutions = [{'deps_file': '.DEPS.git', 'manag ed': True, 'name': 'src', 'url': 'https://chromium.googlesource.com/chromium/src .git'}]",

15 "--root",	9 "--root",

16 "src",	10 "src",

17 "--revision_mapping_file",	11 "--revision_mapping_file",

18 "{\"src\": \"got_cr_revision\"}",	12 "{\"src\": \"got_cr_revision\"}",

19 "--git-cache-dir",	13 "--git-cache-dir",

20 "[GIT_CACHE]",	14 "[GIT_CACHE]",

21 "--output_json",	15 "--output_json",

22 "/path/to/tmp/json",	16 "/path/to/tmp/json",

(...skipping 24 matching lines...) Expand all Loading...
47 "@@@SET_BUILD_PROPERTY@got_cr_revision@\"f27fede2220bcd326aee3e86ddfd4ebd0 fe58cb9\"@@@",	41 "@@@SET_BUILD_PROPERTY@got_cr_revision@\"f27fede2220bcd326aee3e86ddfd4ebd0 fe58cb9\"@@@",

48 "@@@SET_BUILD_PROPERTY@got_cr_revision_cp@\"refs/heads/master@{#170242}\"@ @@"	42 "@@@SET_BUILD_PROPERTY@got_cr_revision_cp@\"refs/heads/master@{#170242}\"@ @@"

49 ]	43 ]

50 },	44 },

51 {	45 {

52 "name": "$result",	46 "name": "$result",

53 "recipe_result": null,	47 "recipe_result": null,

54 "status_code": 0	48 "status_code": 0

55 }	49 }

56 ]	50 ]

OLD	NEW