Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Unified Diff: Source/core/plugins/PluginView.h

Issue 230813002: Make it possible to have <object>'s scriptableObject as a v8 object instead of NPObject. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased to current ToT (by raymes - fetched from https://codereview.chromium.org/426853002/) Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/plugins/PluginView.h
diff --git a/Source/core/plugins/PluginView.h b/Source/core/plugins/PluginView.h
index c1cdc2f61f392b5e8d1f2b48c5997dac77e07ee0..dc18073af38585b3232410befb8ced49560042d5 100644
--- a/Source/core/plugins/PluginView.h
+++ b/Source/core/plugins/PluginView.h
@@ -1,6 +1,7 @@
/*
* Copyright (C) 2010 Apple Inc. All rights reserved.
* Copyright (C) 2013 Google Inc. All rights reserved.
+ * Copyright (C) 2014 Opera Software ASA. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -33,6 +34,11 @@
struct NPObject;
namespace blink { class WebLayer; }
+namespace v8 {
+template <typename T> class Local;
+class Isolate;
+class Object;
+}
namespace blink {
@@ -45,7 +51,7 @@ public:
virtual bool isPluginView() const OVERRIDE FINAL { return true; }
virtual blink::WebLayer* platformLayer() const { return 0; }
- virtual NPObject* scriptableObject() { return 0; }
+ virtual void getScriptableObject(v8::Isolate*, v8::Local<v8::Object>*) { }
abarth-chromium 2014/07/29 17:34:21 This should just return a v8::Handle<v8::Object>
Krzysztof Olczyk 2014/07/30 08:40:31 Done.
virtual bool getFormValue(String&) { return false; }
virtual bool wantsWheelEvents() { return false; }
virtual bool supportsKeyboardFocus() const { return false; }

Powered by Google App Engine
This is Rietveld 408576698