Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: Source/core/plugins/PluginView.h

Issue 230813002: Make it possible to have <object>'s scriptableObject as a v8 object instead of NPObject. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased to current ToT (by raymes - fetched from https://codereview.chromium.org/426853002/) Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Google Inc. All rights reserved. 3 * Copyright (C) 2013 Google Inc. All rights reserved.
4 * Copyright (C) 2014 Opera Software ASA. All rights reserved.
4 * 5 *
5 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
7 * are met: 8 * are met:
8 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 11 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the 12 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution. 13 * documentation and/or other materials provided with the distribution.
13 * 14 *
(...skipping 12 matching lines...) Expand all
26 #ifndef PluginView_h 27 #ifndef PluginView_h
27 #define PluginView_h 28 #define PluginView_h
28 29
29 #include "platform/Widget.h" 30 #include "platform/Widget.h"
30 #include "platform/scroll/ScrollTypes.h" 31 #include "platform/scroll/ScrollTypes.h"
31 #include "wtf/text/WTFString.h" 32 #include "wtf/text/WTFString.h"
32 33
33 struct NPObject; 34 struct NPObject;
34 35
35 namespace blink { class WebLayer; } 36 namespace blink { class WebLayer; }
37 namespace v8 {
38 template <typename T> class Local;
39 class Isolate;
40 class Object;
41 }
36 42
37 namespace blink { 43 namespace blink {
38 44
39 class ResourceError; 45 class ResourceError;
40 class ResourceResponse; 46 class ResourceResponse;
41 class Scrollbar; 47 class Scrollbar;
42 48
43 class PluginView : public Widget { 49 class PluginView : public Widget {
44 public: 50 public:
45 virtual bool isPluginView() const OVERRIDE FINAL { return true; } 51 virtual bool isPluginView() const OVERRIDE FINAL { return true; }
46 52
47 virtual blink::WebLayer* platformLayer() const { return 0; } 53 virtual blink::WebLayer* platformLayer() const { return 0; }
48 virtual NPObject* scriptableObject() { return 0; } 54 virtual void getScriptableObject(v8::Isolate*, v8::Local<v8::Object>*) { }
abarth-chromium 2014/07/29 17:34:21 This should just return a v8::Handle<v8::Object>
Krzysztof Olczyk 2014/07/30 08:40:31 Done.
49 virtual bool getFormValue(String&) { return false; } 55 virtual bool getFormValue(String&) { return false; }
50 virtual bool wantsWheelEvents() { return false; } 56 virtual bool wantsWheelEvents() { return false; }
51 virtual bool supportsKeyboardFocus() const { return false; } 57 virtual bool supportsKeyboardFocus() const { return false; }
52 virtual bool supportsInputMethod() const { return false; } 58 virtual bool supportsInputMethod() const { return false; }
53 virtual bool canProcessDrag() const { return false; } 59 virtual bool canProcessDrag() const { return false; }
54 60
55 virtual void didReceiveResponse(const ResourceResponse&) { } 61 virtual void didReceiveResponse(const ResourceResponse&) { }
56 virtual void didReceiveData(const char*, int) { } 62 virtual void didReceiveData(const char*, int) { }
57 virtual void didFinishLoading() { } 63 virtual void didFinishLoading() { }
58 virtual void didFailLoading(const ResourceError&) { } 64 virtual void didFailLoading(const ResourceError&) { }
59 65
60 protected: 66 protected:
61 PluginView() : Widget() { } 67 PluginView() : Widget() { }
62 }; 68 };
63 69
64 DEFINE_TYPE_CASTS(PluginView, Widget, widget, widget->isPluginView(), widget.isP luginView()); 70 DEFINE_TYPE_CASTS(PluginView, Widget, widget, widget->isPluginView(), widget.isP luginView());
65 71
66 } // namespace blink 72 } // namespace blink
67 73
68 #endif // PluginView_h 74 #endif // PluginView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698