Fix printing of directory name on gn clean failure

Fix printing of directory name on gn clean failure

The 'gn clean' code that detects whether something is a build directory
was, on Windows, printing a wchar_t* string using %s with a char*
format string. This means that only the drive letter gets printed.
Fixed by using FilePathToUTF8().

Running /analyze on gn confirmed that this is the only bug of its type
and found a few other more minor glitches, filed as part of the
referenced bug.

BUG=643842
Committed: https://crrev.com/e17ac37d6c181f2d4ec5ac51eda4717af3505596
Cr-Commit-Position: refs/heads/master@{#416651}

[brucedawson, 2016-09-02 22:26:28]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 22:27:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-09-02 22:27:14]

brucedawson@chromium.org changed reviewers:
+ brettw@chromium.org

[brucedawson, 2016-09-02 22:50:51]

Description was changed from

==========
Fix printing of directory name on gn clean failure

The 'gn clean' code that detects whether something is a build directory
was, on Windows, printing a wchar_t* string using %s with a char*
format string. This means that only the drive letter gets printed.
Fixed by using FilePathToUTF8().

I'm going to follow up by running /analyze on gn and the rest of Chrome
once Update 3 lands.
==========

to

==========
Fix printing of directory name on gn clean failure

The 'gn clean' code that detects whether something is a build directory
was, on Windows, printing a wchar_t* string using %s with a char*
format string. This means that only the drive letter gets printed.
Fixed by using FilePathToUTF8().

Running /analyze on gn confirmed that this is the only bug of its type
and found a few other more minor glitches, filed as part of the
referenced bug.

BUG=643842
==========

[commit-bot: I haz the power, 2016-09-02 23:06:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 23:06:52]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-09-06 00:57:38]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-09-06 00:57:38]

lgtm

[brucedawson, 2016-09-06 16:38:15]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-09-06 16:38:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-09-06 17:29:29]

lgtm

[commit-bot: I haz the power, 2016-09-06 17:44:19]

Description was changed from

==========
Fix printing of directory name on gn clean failure

The 'gn clean' code that detects whether something is a build directory
was, on Windows, printing a wchar_t* string using %s with a char*
format string. This means that only the drive letter gets printed.
Fixed by using FilePathToUTF8().

Running /analyze on gn confirmed that this is the only bug of its type
and found a few other more minor glitches, filed as part of the
referenced bug.

BUG=643842
==========

to

==========
Fix printing of directory name on gn clean failure

The 'gn clean' code that detects whether something is a build directory
was, on Windows, printing a wchar_t* string using %s with a char*
format string. This means that only the drive letter gets printed.
Fixed by using FilePathToUTF8().

Running /analyze on gn confirmed that this is the only bug of its type
and found a few other more minor glitches, filed as part of the
referenced bug.

BUG=643842
==========

[commit-bot: I haz the power, 2016-09-06 17:44:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-06 17:48:10]

Description was changed from

==========
Fix printing of directory name on gn clean failure

The 'gn clean' code that detects whether something is a build directory
was, on Windows, printing a wchar_t* string using %s with a char*
format string. This means that only the drive letter gets printed.
Fixed by using FilePathToUTF8().

Running /analyze on gn confirmed that this is the only bug of its type
and found a few other more minor glitches, filed as part of the
referenced bug.

BUG=643842
==========

to

==========
Fix printing of directory name on gn clean failure

The 'gn clean' code that detects whether something is a build directory
was, on Windows, printing a wchar_t* string using %s with a char*
format string. This means that only the drive letter gets printed.
Fixed by using FilePathToUTF8().

Running /analyze on gn confirmed that this is the only bug of its type
and found a few other more minor glitches, filed as part of the
referenced bug.

BUG=643842

Committed: https://crrev.com/e17ac37d6c181f2d4ec5ac51eda4717af3505596
Cr-Commit-Position: refs/heads/master@{#416651}
==========

[commit-bot: I haz the power, 2016-09-06 17:48:10]

Patchset 1 (id:??) landed as
https://crrev.com/e17ac37d6c181f2d4ec5ac51eda4717af3505596
Cr-Commit-Position: refs/heads/master@{#416651}