Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1384)

Unified Diff: tools/gn/command_clean.cc

Issue 2308113002: Fix printing of directory name on gn clean failure (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_clean.cc
diff --git a/tools/gn/command_clean.cc b/tools/gn/command_clean.cc
index d14b22d84a39e7f3949c097c180f03bc9bade75e..f0348d94229a0719ca8e27e289927711cc452619 100644
--- a/tools/gn/command_clean.cc
+++ b/tools/gn/command_clean.cc
@@ -8,6 +8,7 @@
#include "base/strings/stringprintf.h"
#include "tools/gn/commands.h"
#include "tools/gn/err.h"
+#include "tools/gn/filesystem_utils.h"
#include "tools/gn/setup.h"
namespace {
@@ -84,8 +85,9 @@ int RunClean(const std::vector<std::string>& args) {
base::FilePath build_ninja_d_file = build_dir.AppendASCII("build.ninja.d");
if (!base::PathExists(build_ninja_d_file)) {
Err(Location(),
- base::StringPrintf("%s does not look like a build directory.\n",
- build_ninja_d_file.DirName().value().c_str()))
+ base::StringPrintf(
+ "%s does not look like a build directory.\n",
+ FilePathToUTF8(build_ninja_d_file.DirName().value()).c_str()))
.PrintToStdout();
return 1;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698