Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2308103002: Disable WebView/Chrome's drag and drop feature on M and below. (Closed)

Created:
4 years, 3 months ago by hush (inactive)
Modified:
4 years, 3 months ago
Reviewers:
Ted C
CC:
chromium-reviews, jam, darin-cc_chromium.org, sgurun-gerrit only
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable WebView/Chrome's drag and drop feature on M and below. We've made a decision that drag and drop will be supported on N+ only. This CL disables drag and drop on M and below, and makes sure blink is not stuck in a drag and drop pending state. BUG=643765 Committed: https://crrev.com/865edaf64571cb9147d49d59d591300b50087234 Cr-Commit-Position: refs/heads/master@{#416376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M content/browser/web_contents/web_contents_view_android.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +5 lines, -1 line 0 comments Download
M ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java View 2 chunks +8 lines, -5 lines 0 comments Download
M ui/android/view_android.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/android/view_android.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hush (inactive)
Hello Ted, PTAL
4 years, 3 months ago (2016-09-02 22:01:03 UTC) #2
Ted C
lgtm
4 years, 3 months ago (2016-09-02 22:08:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2308103002/1
4 years, 3 months ago (2016-09-02 22:12:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 22:58:59 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 23:01:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/865edaf64571cb9147d49d59d591300b50087234
Cr-Commit-Position: refs/heads/master@{#416376}

Powered by Google App Engine
This is Rietveld 408576698