content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 2308103002: Disable WebView/Chrome's drag and drop feature on M and below.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2308103002: Disable WebView/Chrome's drag and drop feature on M and below. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/web_contents_view_android.cc ('k') | ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 12abff599f8dfa9dd76f52e5b06bc1444838b6bc..d0c951da7c477f2ad72424b826e488c551975a40 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -3142,8 +3142,12 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Screen

/**

* @see View#onDragEvent(DragEvent)

+ // TODO(hush): uncomment below when we build with API 24.

+ // @TargetApi(Build.VERSION_CODES.N)

public boolean onDragEvent(DragEvent event) {

- if (mNativeContentViewCore == 0) return false;

+ if (mNativeContentViewCore == 0 || Build.VERSION.SDK_INT <= Build.VERSION_CODES.M) {

+ return false;

+ }

ClipDescription clipDescription = event.getClipDescription();