Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2308093002: Disable C4467 'usage of ATL attributes is deprecated' in midi (Closed)

Created:
4 years, 3 months ago by scottmg
Modified:
4 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable C4467 'usage of ATL attributes is deprecated' in midi robuffer.h causes d:\src\depot_tools\win_toolchain\vs_files\d5dc33b15d1b2c086f2f6632e2fd15882f80dbd3\win_sdk\include\10.0.10586.0\winrt\robuffer.h(46): warning C4467: usage of ATL attributes is deprecated on VS2015 Update 3. (Confirmed via trybot that Update 2 doesn't warn about not understanding this warning being disabled.) BUG=627216, 637456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/midi/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
scottmg
4 years, 3 months ago (2016-09-02 21:21:15 UTC) #3
brucedawson
lgtm
4 years, 3 months ago (2016-09-02 21:27:37 UTC) #7
qiankun
I fixed this issue in another way: https://codereview.chromium.org/2301523008/.
4 years, 3 months ago (2016-09-03 01:39:24 UTC) #12
scottmg
On 2016/09/03 01:39:24, qiankun wrote: > I fixed this issue in another way: https://codereview.chromium.org/2301523008/. Thanks!
4 years, 3 months ago (2016-09-03 02:35:11 UTC) #13
Takashi Toyoshima
Thank you guys for handling this issue, and sorry for overlooking this error.
4 years, 3 months ago (2016-09-05 06:19:50 UTC) #14
scottmg
4 years, 3 months ago (2016-09-06 17:39:34 UTC) #15
Message was sent while issue was closed.
On 2016/09/05 06:19:50, toyoshim wrote:
> Thank you guys for handling this issue, and sorry for overlooking this error.

No problem, nothing to overlook -- we haven't switched to this release of the
compiler yet so there's no way you could have known.

Powered by Google App Engine
This is Rietveld 408576698