Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2306193002: Fix antialiasing ppapi settings, browser_tests in win32k lockdown (Closed)

Created:
4 years, 3 months ago by scottmg
Modified:
4 years, 3 months ago
Reviewers:
Nico, piman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix antialiasing ppapi settings, browser_tests in win32k lockdown PpapiPluginMain was calling font and dpi retrieval functions which don't work in lockdown. Pass those values on the command line instead. BUG=258201, 615375 Committed: https://crrev.com/e66b57781d08e764d749b5440c7e940bb3fc3700 Cr-Commit-Position: refs/heads/master@{#416704}

Patch Set 1 #

Patch Set 2 : fix ppapi setup #

Patch Set 3 : no fatal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -8 lines) Patch
M content/browser/ppapi_plugin_process_host.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M content/ppapi_plugin/ppapi_plugin_main.cc View 1 3 chunks +19 lines, -8 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 32 (23 generated)
scottmg
piman: content/ thakis: another try at ui/gfx/win/singleton_hwnd.cc
4 years, 3 months ago (2016-09-03 00:19:51 UTC) #9
piman
lgtm
4 years, 3 months ago (2016-09-03 00:46:01 UTC) #13
Nico
lgtm
4 years, 3 months ago (2016-09-03 02:07:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306193002/40001
4 years, 3 months ago (2016-09-03 02:41:40 UTC) #19
commit-bot: I haz the power
Exceeded global retry quota
4 years, 3 months ago (2016-09-03 04:41:14 UTC) #21
scottmg
Still more places that trigger the DLOG(FATAL), so not yet. :/ Removed that part.
4 years, 3 months ago (2016-09-06 18:28:03 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306193002/60001
4 years, 3 months ago (2016-09-06 18:29:50 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 3 months ago (2016-09-06 20:31:05 UTC) #30
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 20:33:56 UTC) #32
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e66b57781d08e764d749b5440c7e940bb3fc3700
Cr-Commit-Position: refs/heads/master@{#416704}

Powered by Google App Engine
This is Rietveld 408576698