|
|
DescriptionFix antialiasing ppapi settings, browser_tests in win32k lockdown
PpapiPluginMain was calling font and dpi retrieval functions which
don't work in lockdown. Pass those values on the command line instead.
BUG=258201, 615375
Committed: https://crrev.com/e66b57781d08e764d749b5440c7e940bb3fc3700
Cr-Commit-Position: refs/heads/master@{#416704}
Patch Set 1 #Patch Set 2 : fix ppapi setup #Patch Set 3 : no fatal #
Depends on Patchset: Messages
Total messages: 32 (23 generated)
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
Description was changed from ========== Fix browser_tests and then add missing DLOG(FATAL) in SingletonHwnd BUG=258201 ========== to ========== Fix browser_tests and then add missing DLOG(FATAL) in SingletonHwnd BUG=258201,615375 ==========
Description was changed from ========== Fix browser_tests and then add missing DLOG(FATAL) in SingletonHwnd BUG=258201,615375 ========== to ========== Fix browser_tests and then add missing DLOG(FATAL) in SingletonHwnd PpapiPluginMain was calling font and dpi retrieval functions which don't work in lockdown. Pass those values on the command line instead. Enable DLOG(FATAL) in SingletonHwnd the log for which was recently removed to catch similar future regressions. BUG=258201,615375 ==========
Description was changed from ========== Fix browser_tests and then add missing DLOG(FATAL) in SingletonHwnd PpapiPluginMain was calling font and dpi retrieval functions which don't work in lockdown. Pass those values on the command line instead. Enable DLOG(FATAL) in SingletonHwnd the log for which was recently removed to catch similar future regressions. BUG=258201,615375 ========== to ========== Fix antialiasing ppapi settings, browser_tests, and then add missing DLOG(FATAL) in SingletonHwnd PpapiPluginMain was calling font and dpi retrieval functions which don't work in lockdown. Pass those values on the command line instead. Enable DLOG(FATAL) in SingletonHwnd the log for which was recently removed to catch similar future regressions. BUG=258201,615375 ==========
scottmg@chromium.org changed reviewers: + piman@chromium.org, thakis@chromium.org
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
piman: content/ thakis: another try at ui/gfx/win/singleton_hwnd.cc
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
lgtm
lgtm
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by scottmg@chromium.org
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
Description was changed from ========== Fix antialiasing ppapi settings, browser_tests, and then add missing DLOG(FATAL) in SingletonHwnd PpapiPluginMain was calling font and dpi retrieval functions which don't work in lockdown. Pass those values on the command line instead. Enable DLOG(FATAL) in SingletonHwnd the log for which was recently removed to catch similar future regressions. BUG=258201,615375 ========== to ========== Fix antialiasing ppapi settings, browser_tests, and then add missing DLOG(FATAL) in SingletonHwnd PpapiPluginMain was calling font and dpi retrieval functions which don't work in lockdown. Pass those values on the command line instead. BUG=258201,615375 ==========
Description was changed from ========== Fix antialiasing ppapi settings, browser_tests, and then add missing DLOG(FATAL) in SingletonHwnd PpapiPluginMain was calling font and dpi retrieval functions which don't work in lockdown. Pass those values on the command line instead. BUG=258201,615375 ========== to ========== Fix antialiasing ppapi settings, browser_tests PpapiPluginMain was calling font and dpi retrieval functions which don't work in lockdown. Pass those values on the command line instead. BUG=258201,615375 ==========
Still more places that trigger the DLOG(FATAL), so not yet. :/ Removed that part.
Description was changed from ========== Fix antialiasing ppapi settings, browser_tests PpapiPluginMain was calling font and dpi retrieval functions which don't work in lockdown. Pass those values on the command line instead. BUG=258201,615375 ========== to ========== Fix antialiasing ppapi settings, browser_tests in win32k lockdown PpapiPluginMain was calling font and dpi retrieval functions which don't work in lockdown. Pass those values on the command line instead. BUG=258201,615375 ==========
The CQ bit was checked by scottmg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org, piman@chromium.org Link to the patchset: https://codereview.chromium.org/2306193002/#ps60001 (title: "no fatal")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix antialiasing ppapi settings, browser_tests in win32k lockdown PpapiPluginMain was calling font and dpi retrieval functions which don't work in lockdown. Pass those values on the command line instead. BUG=258201,615375 ========== to ========== Fix antialiasing ppapi settings, browser_tests in win32k lockdown PpapiPluginMain was calling font and dpi retrieval functions which don't work in lockdown. Pass those values on the command line instead. BUG=258201,615375 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Fix antialiasing ppapi settings, browser_tests in win32k lockdown PpapiPluginMain was calling font and dpi retrieval functions which don't work in lockdown. Pass those values on the command line instead. BUG=258201,615375 ========== to ========== Fix antialiasing ppapi settings, browser_tests in win32k lockdown PpapiPluginMain was calling font and dpi retrieval functions which don't work in lockdown. Pass those values on the command line instead. BUG=258201,615375 Committed: https://crrev.com/e66b57781d08e764d749b5440c7e940bb3fc3700 Cr-Commit-Position: refs/heads/master@{#416704} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/e66b57781d08e764d749b5440c7e940bb3fc3700 Cr-Commit-Position: refs/heads/master@{#416704} |