Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2307903003: Add v8_enable_inspector_override to build_config/v8.gni. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 3 months ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add v8_enable_inspector_override to build_config/v8.gni. This is in a preparation to introduce this flag in v8. BUG=635948 Committed: https://crrev.com/4acd1821efa01e00c3a0efec1ae2430eb6d127db Cr-Commit-Position: refs/heads/master@{#416681}

Patch Set 1 #

Total comments: 2

Patch Set 2 : false #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build_overrides/v8.gni View 1 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
dgozman
Could you please take a look? This is a prerequisite for 2292053003.
4 years, 3 months ago (2016-09-03 01:20:17 UTC) #2
Michael Achenbach
lgtm with comment: https://codereview.chromium.org/2307903003/diff/1/build_overrides/v8.gni File build_overrides/v8.gni (right): https://codereview.chromium.org/2307903003/diff/1/build_overrides/v8.gni#newcode23 build_overrides/v8.gni:23: v8_enable_inspector_override = true Please start out ...
4 years, 3 months ago (2016-09-05 06:44:04 UTC) #3
dgozman
https://codereview.chromium.org/2307903003/diff/1/build_overrides/v8.gni File build_overrides/v8.gni (right): https://codereview.chromium.org/2307903003/diff/1/build_overrides/v8.gni#newcode23 build_overrides/v8.gni:23: v8_enable_inspector_override = true On 2016/09/05 06:44:04, machenbach (slow) wrote: ...
4 years, 3 months ago (2016-09-06 17:38:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307903003/20001
4 years, 3 months ago (2016-09-06 17:38:48 UTC) #7
Michael Achenbach
lgtm
4 years, 3 months ago (2016-09-06 18:26:06 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-06 18:47:06 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 18:48:52 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4acd1821efa01e00c3a0efec1ae2430eb6d127db
Cr-Commit-Position: refs/heads/master@{#416681}

Powered by Google App Engine
This is Rietveld 408576698