Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2307853002: [regexp] Port RegExpExec (Closed)

Created:
4 years, 3 months ago by jgruber
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Port RegExpExec BUG=v8:5339 Committed: https://crrev.com/c79e163ba82f2e2dcf9b60639127d187fdbf54b9 Cr-Commit-Position: refs/heads/master@{#39150}

Patch Set 1 #

Patch Set 2 : Remove unused function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -56 lines) Patch
M src/bootstrapper.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 1 3 chunks +136 lines, -3 lines 0 comments Download
M src/heap-symbols.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/js/regexp.js View 4 chunks +3 lines, -48 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
jgruber
4 years, 3 months ago (2016-09-02 13:12:24 UTC) #10
Benedikt Meurer
LGTM.
4 years, 3 months ago (2016-09-02 17:15:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307853002/20001
4 years, 3 months ago (2016-09-05 06:51:13 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-05 07:17:16 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c79e163ba82f2e2dcf9b60639127d187fdbf54b9 Cr-Commit-Position: refs/heads/master@{#39150}
4 years, 3 months ago (2016-09-05 07:17:55 UTC) #16
jgruber
4 years, 3 months ago (2016-09-05 11:52:41 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2315473002/ by jgruber@chromium.org.

The reason for reverting is: Performance regressions: crbug.com/644087
Clusterfuzz: crbug.com/644074

We'll reland all regexp changes at once when the port is complete and at least
performance-neutral, since the partial port requires slow workarounds..

Powered by Google App Engine
This is Rietveld 408576698