Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2307863003: [regexp] Port RegExpMatch, RegExpSearch, and RegExpTest (Closed)

Created:
4 years, 3 months ago by jgruber
Modified:
4 years, 3 months ago
Reviewers:
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Port RegExpMatch, RegExpSearch, and RegExpTest BUG=

Patch Set 1 #

Patch Set 2 : Fix OOB index #

Patch Set 3 : Fix issues related to non-smi lastIndex #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -136 lines) Patch
M src/bootstrapper.cc View 1 2 3 3 chunks +20 lines, -3 lines 0 comments Download
M src/builtins/builtins.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 1 2 3 3 chunks +342 lines, -3 lines 0 comments Download
M src/heap-symbols.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M src/js/regexp.js View 1 2 3 5 chunks +3 lines, -128 lines 0 comments Download
M src/objects.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (21 generated)
jgruber
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-02 13:13:34 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307863003/1
4 years, 3 months ago (2016-09-02 13:13:45 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-02 13:33:21 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/12055) v8_linux_dbg_ng_triggered on ...
4 years, 3 months ago (2016-09-02 13:33:22 UTC) #4
jgruber
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-02 13:48:38 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307863003/20001
4 years, 3 months ago (2016-09-02 13:48:43 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-02 14:02:58 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/8137) v8_mac_rel_ng_triggered on ...
4 years, 3 months ago (2016-09-02 14:02:59 UTC) #8
jgruber
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-02 14:59:13 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307863003/40001
4 years, 3 months ago (2016-09-02 14:59:18 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-02 14:59:19 UTC) #11
commit-bot: I haz the power
Dry run: CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in ...
4 years, 3 months ago (2016-09-02 14:59:19 UTC) #12
jgruber
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-04 17:53:15 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307863003/40001
4 years, 3 months ago (2016-09-04 17:53:22 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-04 17:53:23 UTC) #15
commit-bot: I haz the power
Dry run: CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in ...
4 years, 3 months ago (2016-09-04 17:53:23 UTC) #16
jgruber
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-04 19:14:18 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307863003/60001
4 years, 3 months ago (2016-09-04 19:14:20 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-04 19:41:13 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 3 months ago (2016-09-04 19:41:14 UTC) #20
jgruber
4 years, 3 months ago (2016-09-06 11:06:03 UTC) #21 
Description was changed from

==========
[regexp] Port RegExpMatch, RegExpSearch, and RegExpTest

BUG=
==========

to

==========
[regexp] Port RegExpMatch, RegExpSearch, and RegExpTest

BUG=
==========

Powered by Google App Engine
This is Rietveld 408576698