Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 2307783002: Do not include Error.captureStackTrace in the trace (Closed)

Created:
4 years, 3 months ago by jgruber
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, ofrobots
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not include Error.captureStackTrace in the trace BUG=v8:5342 Committed: https://crrev.com/64c518d06d6a947c466e0948980054308f33cd66 Cr-Commit-Position: refs/heads/master@{#39124}

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M src/builtins/builtins-error.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -9 lines 0 comments Download
A + test/mjsunit/regress/regress-5342.js View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
jgruber
4 years, 3 months ago (2016-09-02 08:18:38 UTC) #6
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-02 09:14:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307783002/20001
4 years, 3 months ago (2016-09-02 09:23:55 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-02 09:51:08 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 09:51:55 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/64c518d06d6a947c466e0948980054308f33cd66
Cr-Commit-Position: refs/heads/master@{#39124}

Powered by Google App Engine
This is Rietveld 408576698