Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: src/isolate.cc

Issue 2307783002: Do not include Error.captureStackTrace in the trace (Closed)
Patch Set: Add test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-error.cc ('k') | test/mjsunit/regress/regress-5342.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index dcf0dbd4c42b0cc4c3c5b19a08c2fdb327466c5f..0b4ef139e76c61712cfd669b9bd55b24a2634be1 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -324,17 +324,8 @@ class StackTraceHelper {
mode_(mode),
caller_(caller),
skip_next_frame_(true) {
- // The caller parameter can be used to skip a specific set of frames in the
- // stack trace. It can be:
- // * null, when called from a standard error constructor. We unconditionally
- // skip the top frame, which is always a builtin-exit frame for the error
- // constructor builtin.
- // * a JSFunction, when called by the user from Error.captureStackTrace().
- // We skip each frame until encountering the caller function.
- // * For any other value, all frames are included in the trace.
switch (mode_) {
case SKIP_FIRST:
- DCHECK(caller_.is_null());
skip_next_frame_ = true;
break;
case SKIP_UNTIL_SEEN:
« no previous file with comments | « src/builtins/builtins-error.cc ('k') | test/mjsunit/regress/regress-5342.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698