Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 2307613002: Remove style checks which require the use of Pass*Ptr in return and parameter types. (Closed)

Created:
4 years, 3 months ago by jbroman
Modified:
4 years, 3 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove style checks which require the use of Pass*Ptr in return and parameter types. BUG=494719 Committed: https://crrev.com/f30aa959595baaaa83f43d13cb08c8159c7aea99 Cr-Commit-Position: refs/heads/master@{#416265}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -55 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py View 2 chunks +0 lines, -25 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py View 3 chunks +0 lines, -30 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jbroman
Per the blink-dev thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/h21zh25fvpE/discussion It seems I should be using RefPtr<T> alone (with std::move) ...
4 years, 3 months ago (2016-09-01 17:50:05 UTC) #4
Yuta Kitamura
lgtm
4 years, 3 months ago (2016-09-02 02:17:20 UTC) #7
Bugs Nash
lgtm
4 years, 3 months ago (2016-09-02 04:05:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307613002/1
4 years, 3 months ago (2016-09-02 15:05:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 15:08:55 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 15:11:05 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f30aa959595baaaa83f43d13cb08c8159c7aea99
Cr-Commit-Position: refs/heads/master@{#416265}

Powered by Google App Engine
This is Rietveld 408576698