Remove style checks which require the use of Pass*Ptr in return and parameter types.

third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py

 # -*- coding: utf-8 -*-
 #
 # Copyright (C) 2009, 2010, 2012 Google Inc. All rights reserved.
 # Copyright (C) 2009 Torch Mobile Inc.
 # Copyright (C) 2009 Apple Inc. All rights reserved.
 # Copyright (C) 2010 Chris Jerdonek (cjerdonek@webkit.org)
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
@@ skipping 1704 matching lines @@
 
     # Used to detect cases like ec for ExceptionCode.
     acronym = _create_acronym(text).lower()
     if canonical_text.find(canonical_parameter_name) != -1 or acronym.find(canonical_parameter_name) != -1:
         error(parameter.row, 'readability/parameter_name', 5,
               'The parameter name "%s" adds no information, so it should be removed.' % parameter.name)
         return False
     return True
 
 
-def check_function_definition_and_pass_ptr(type_text, row, location_description, error):
-    """Check that function definitions for use Pass*Ptr instead of *Ptr.
-
-    Args:
-       type_text: A string containing the type. (For return values, it may contain more than the type.)
-       row: The row number of the type.
-       location_description: Used to indicate where the type is. This is either 'parameter' or 'return'.
-       error: The function to call with any errors found.
-    """
-    match_ref_or_own_ptr = '(?=\W|^)(Ref|Own)Ptr(WillBeRawPtr)?(?=\W)'
-    exceptions = '(?:&|\*|\*\s*=\s*(0|nullptr))$'
-    bad_type_usage = search(match_ref_or_own_ptr, type_text)
-    exception_usage = search(exceptions, type_text)
-    if not bad_type_usage or exception_usage:
-        return
-    type_name = bad_type_usage.group(0)
-    error(row, 'readability/pass_ptr', 5,
-          'The %s type should use Pass%s instead of %s.' % (location_description, type_name, type_name))
-
-
 def check_function_definition(filename, file_extension, clean_lines, line_number, function_state, error):
     """Check that function definitions for style issues.
 
     Specifically, check that parameter names in declarations add information.
 
     Args:
        filename: Filename of the file that is being processed.
        file_extension: The current file extension, without the leading dot.
        clean_lines: A CleansedLines instance containing the file.
        line_number: The number of the line to check.
@@ skipping 12 matching lines @@
         elif not file_extension == "h":
             error(function_state.function_name_start_position.row, 'readability/webkit_export', 5,
                   'WEBKIT_EXPORT should only be used in header files.')
         elif not function_state.is_declaration or search(r'\binline\b', modifiers_and_return_type):
             error(function_state.function_name_start_position.row, 'readability/webkit_export', 5,
                   'WEBKIT_EXPORT should not be used on a function with a body.')
         elif function_state.is_pure:
             error(function_state.function_name_start_position.row, 'readability/webkit_export', 5,
                   'WEBKIT_EXPORT should not be used with a pure virtual function.')
 
-    check_function_definition_and_pass_ptr(
-        modifiers_and_return_type, function_state.function_name_start_position.row, 'return', error)
-
     parameter_list = function_state.parameter_list()
     for parameter in parameter_list:
-        check_function_definition_and_pass_ptr(parameter.type, parameter.row, 'parameter', error)
-
         # Do checks specific to function declarations and parameter names.
         if not function_state.is_declaration or not parameter.name:
             continue
 
         # Check the parameter name against the function name for single parameter set functions.
         if len(parameter_list) == 1 and match('set[A-Z]', function_state.current_function):
             trimmed_function_name = function_state.current_function[len('set'):]
             if not _check_parameter_name_against_text(parameter, trimmed_function_name, error):
                 continue  # Since an error was noted for this name, move to the next parameter.
 
@@ skipping 2414 matching lines @@
 
     def check(self, lines):
         _process_lines(self.file_path, self.file_extension, lines,
                        self.handle_style_error, self.min_confidence)
 
 
 # FIXME: Remove this function (requires refactoring unit tests).
 def process_file_data(filename, file_extension, lines, error, min_confidence, fs=None):
     checker = CppChecker(filename, file_extension, error, min_confidence, fs)
     checker.check(lines)