Remove HTMLSourceElement media listener if media attribute is empty

Remove HTMLSourceElement media listener if media attribute is empty

This CL removes the MediaQueryListener from HTMLSourceElement that their
media attribute was removed.

BUG=643972
Committed: https://crrev.com/626cb8e7078d2d0bc98be866c664e201c3434ad2
Cr-Commit-Position: refs/heads/master@{#417176}

[Yoav Weiss, 2016-09-04 19:45:39]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2016-09-04 19:45:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoav Weiss, 2016-09-04 19:57:51]

yoav@yoav.ws changed reviewers:
+ cbiesinger@chromium.org

[Yoav Weiss, 2016-09-04 19:57:52]

Hey Christian,

Here's the change we discussed at the previous CL. I initially thought it's
observable, but eventually since removing a media attribute means that the
resource is picked anyway, the presence of the MQListener is not really
triggering any downloads that shouldn't happen anyway.

Can you take a look?

[commit-bot: I haz the power, 2016-09-04 21:09:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-04 21:09:47]

Dry run: This issue passed the CQ dry run.

[cbiesinger, 2016-09-07 16:01:42]

lgtm

https://codereview.chromium.org/2307353002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLSourceElement.cpp (right):

https://codereview.chromium.org/2307353002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLSourceElement.cpp:89: m_mediaQueryList =
MediaQueryList::create(&document(), &document().mediaQueryMatcher(), set);
Should this also be set to null if media.isEmpty()?

[Yoav Weiss, 2016-09-07 20:06:01]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 20:07:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoav Weiss, 2016-09-07 20:26:37]

On 2016/09/07 16:01:42, cbiesinger wrote:
> lgtm
> 
>
https://codereview.chromium.org/2307353002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/html/HTMLSourceElement.cpp (right):
> 
>
https://codereview.chromium.org/2307353002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/html/HTMLSourceElement.cpp:89: m_mediaQueryList
=
> MediaQueryList::create(&document(), &document().mediaQueryMatcher(), set);
> Should this also be set to null if media.isEmpty()?

Sure, that way GC might collect it sooner. Changed

[commit-bot: I haz the power, 2016-09-07 23:15:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 23:15:33]

Dry run: This issue passed the CQ dry run.

[Yoav Weiss, 2016-09-08 02:53:55]

The CQ bit was checked by yoav@yoav.ws

[Yoav Weiss, 2016-09-08 02:53:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2307353002/#ps20001
(title: "nullify mqlist")

[commit-bot: I haz the power, 2016-09-08 02:54:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 02:58:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-08 03:00:57]

Description was changed from

==========
Remove HTMLSourceElement media listener if media attribute is empty

This CL removes the MediaQueryListener from HTMLSourceElement that their
media attribute was removed.

BUG=643972
==========

to

==========
Remove HTMLSourceElement media listener if media attribute is empty

This CL removes the MediaQueryListener from HTMLSourceElement that their
media attribute was removed.

BUG=643972

Committed: https://crrev.com/626cb8e7078d2d0bc98be866c664e201c3434ad2
Cr-Commit-Position: refs/heads/master@{#417176}
==========

[commit-bot: I haz the power, 2016-09-08 03:00:59]

Patchset 2 (id:??) landed as
https://crrev.com/626cb8e7078d2d0bc98be866c664e201c3434ad2
Cr-Commit-Position: refs/heads/master@{#417176}