Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSourceElement.cpp

Issue 2307353002: Remove HTMLSourceElement media listener if media attribute is empty (Closed)
Patch Set: nullify mqlist Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLSourceElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp b/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp
index f65e834ef53fbc00b5fdca11d4ed3da34a3eb7a1..184cbabc20648081bf075f05cd45bf1901dc6a9d 100644
--- a/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp
@@ -81,10 +81,12 @@ HTMLSourceElement::~HTMLSourceElement()
void HTMLSourceElement::createMediaQueryList(const AtomicString& media)
{
- if (media.isEmpty())
+ removeMediaQueryListListener();
+ if (media.isEmpty()) {
+ m_mediaQueryList = nullptr;
return;
+ }
- removeMediaQueryListListener();
MediaQuerySet* set = MediaQuerySet::create(media);
m_mediaQueryList = MediaQueryList::create(&document(), &document().mediaQueryMatcher(), set);
addMediaQueryListListener();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698