Remove dead uses of FilterEffect::determineMaximumEffectRect

Remove dead uses of FilterEffect::determineMaximumEffectRect

Said method only computes m_maxEffectRect. The only users of this data
is SVGFilterPainter, directly and via determineAbsolutePaintRect (which
in turn uses mapPaintRect which uses maxEffectRect in one case.) Hence
all other callsites are calling determineMaximumEffectRect() without
making use of the side-effect is has. Remove those uses.
This also mean that we can tailor the method for the one remaining
user by cleaning up, and removing, the flags argument.

TBR=senorblanco@chromium.org
BUG=642035
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/c72d8131504201948d6828472d0bdfaf92c11eb5
Cr-Commit-Position: refs/heads/master@{#416888}

[fs, 2016-09-04 17:19:03]

Description was changed from

==========
Remove dead uses of FilterEffect::determineMaximumEffectRect

Said method only computes m_maxEffectRect. The only users of this data
is SVGFilterPainter, directly and via determineAbsolutePaintRect (which
in turn uses mapPaintRect which uses maxEffectRect in one case.) Hence
all other callsites are calling determineMaximumEffectRect() without
making use of the side-effect is has. Remove those uses.
This also mean that we can tailor the method for the one remaining
user by cleaning up, and removing, the flags argument.

BUG=642035
==========

to

==========
Remove dead uses of FilterEffect::determineMaximumEffectRect

Said method only computes m_maxEffectRect. The only users of this data
is SVGFilterPainter, directly and via determineAbsolutePaintRect (which
in turn uses mapPaintRect which uses maxEffectRect in one case.) Hence
all other callsites are calling determineMaximumEffectRect() without
making use of the side-effect is has. Remove those uses.
This also mean that we can tailor the method for the one remaining
user by cleaning up, and removing, the flags argument.

BUG=642035
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-09-04 17:19:09]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-04 17:19:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-04 18:35:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-04 18:35:34]

Dry run: This issue passed the CQ dry run.

[fs, 2016-09-04 19:04:46]

fs@opera.com changed reviewers:
+ pdr@chromium.org, senorblanco@chromium.org

[pdr., 2016-09-05 02:53:13]

LGTM

[fs, 2016-09-06 18:25:57]

On 2016/09/05 at 02:53:13, pdr wrote:
> LGTM

senorblanco, ping

[pdr., 2016-09-06 18:27:51]

On 2016/09/06 at 18:25:57, fs wrote:
> On 2016/09/05 at 02:53:13, pdr wrote:
> > LGTM
> 
> senorblanco, ping

I checked senorblanco's calendar and it looks like he's on vacation until the
12th :/

I think it's okay to go ahead with this patch but add a TBR=senorblanco

[Stephen Chennney, 2016-09-06 18:28:15]

On 2016/09/06 18:25:57, fs wrote:
> On 2016/09/05 at 02:53:13, pdr wrote:
> > LGTM
> 
> senorblanco, ping

senorblanco is out of office. Maybe find another owner?

[fs, 2016-09-06 18:44:16]

fs@opera.com changed reviewers:
+ junov@chromium.org

[fs, 2016-09-06 18:44:16]

On 2016/09/06 at 18:28:15, schenney wrote:
> senorblanco is out of office. Maybe find another owner?

Let's try junov then.

[fs, 2016-09-07 08:09:35]

On 2016/09/06 at 18:27:51, pdr wrote:
> On 2016/09/06 at 18:25:57, fs wrote:
> > On 2016/09/05 at 02:53:13, pdr wrote:
> > > LGTM
> > 
> > senorblanco, ping
> 
> I checked senorblanco's calendar and it looks like he's on vacation until the
12th :/
> 
> I think it's okay to go ahead with this patch but add a TBR=senorblanco

Doing that now.

[fs, 2016-09-07 08:09:53]

Description was changed from

==========
Remove dead uses of FilterEffect::determineMaximumEffectRect

Said method only computes m_maxEffectRect. The only users of this data
is SVGFilterPainter, directly and via determineAbsolutePaintRect (which
in turn uses mapPaintRect which uses maxEffectRect in one case.) Hence
all other callsites are calling determineMaximumEffectRect() without
making use of the side-effect is has. Remove those uses.
This also mean that we can tailor the method for the one remaining
user by cleaning up, and removing, the flags argument.

BUG=642035
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove dead uses of FilterEffect::determineMaximumEffectRect

Said method only computes m_maxEffectRect. The only users of this data
is SVGFilterPainter, directly and via determineAbsolutePaintRect (which
in turn uses mapPaintRect which uses maxEffectRect in one case.) Hence
all other callsites are calling determineMaximumEffectRect() without
making use of the side-effect is has. Remove those uses.
This also mean that we can tailor the method for the one remaining
user by cleaning up, and removing, the flags argument.

TBR=senorblanco@chromium.org
BUG=642035
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-09-07 08:10:07]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-09-07 08:10:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 09:32:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-07 09:33:56]

Description was changed from

==========
Remove dead uses of FilterEffect::determineMaximumEffectRect

Said method only computes m_maxEffectRect. The only users of this data
is SVGFilterPainter, directly and via determineAbsolutePaintRect (which
in turn uses mapPaintRect which uses maxEffectRect in one case.) Hence
all other callsites are calling determineMaximumEffectRect() without
making use of the side-effect is has. Remove those uses.
This also mean that we can tailor the method for the one remaining
user by cleaning up, and removing, the flags argument.

TBR=senorblanco@chromium.org
BUG=642035
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove dead uses of FilterEffect::determineMaximumEffectRect

Said method only computes m_maxEffectRect. The only users of this data
is SVGFilterPainter, directly and via determineAbsolutePaintRect (which
in turn uses mapPaintRect which uses maxEffectRect in one case.) Hence
all other callsites are calling determineMaximumEffectRect() without
making use of the side-effect is has. Remove those uses.
This also mean that we can tailor the method for the one remaining
user by cleaning up, and removing, the flags argument.

TBR=senorblanco@chromium.org
BUG=642035
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/c72d8131504201948d6828472d0bdfaf92c11eb5
Cr-Commit-Position: refs/heads/master@{#416888}
==========

[commit-bot: I haz the power, 2016-09-07 09:33:57]

Patchset 1 (id:??) landed as
https://crrev.com/c72d8131504201948d6828472d0bdfaf92c11eb5
Cr-Commit-Position: refs/heads/master@{#416888}

[Stephen White, 2016-09-13 18:30:41]

Post-landing LGTM.

Awesome!