Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: third_party/WebKit/Source/core/paint/FilterPainter.cpp

Issue 2307343002: Remove dead uses of FilterEffect::determineMaximumEffectRect (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/paint/FilterPainter.h" 5 #include "core/paint/FilterPainter.h"
6 6
7 #include "core/paint/FilterEffectBuilder.h" 7 #include "core/paint/FilterEffectBuilder.h"
8 #include "core/paint/LayerClipRecorder.h" 8 #include "core/paint/LayerClipRecorder.h"
9 #include "core/paint/PaintLayer.h" 9 #include "core/paint/PaintLayer.h"
10 #include "platform/RuntimeEnabledFeatures.h" 10 #include "platform/RuntimeEnabledFeatures.h"
(...skipping 16 matching lines...) Expand all
27 { 27 {
28 if (!layer.paintsWithFilters()) 28 if (!layer.paintsWithFilters())
29 return; 29 return;
30 30
31 FilterEffect* lastEffect = layer.lastFilterEffect(); 31 FilterEffect* lastEffect = layer.lastFilterEffect();
32 if (!lastEffect) 32 if (!lastEffect)
33 return; 33 return;
34 34
35 DCHECK(layer.filterInfo()); 35 DCHECK(layer.filterInfo());
36 36
37 lastEffect->determineMaximumEffectRect(MapRectForward);
38 sk_sp<SkImageFilter> imageFilter = SkiaImageFilterBuilder::build(lastEffect, ColorSpaceDeviceRGB); 37 sk_sp<SkImageFilter> imageFilter = SkiaImageFilterBuilder::build(lastEffect, ColorSpaceDeviceRGB);
39 if (!imageFilter) 38 if (!imageFilter)
40 return; 39 return;
41 40
42 // We'll handle clipping to the dirty rect before filter rasterization. 41 // We'll handle clipping to the dirty rect before filter rasterization.
43 // Filter processing will automatically expand the clip rect and the offscre en to accommodate any filter outsets. 42 // Filter processing will automatically expand the clip rect and the offscre en to accommodate any filter outsets.
44 // FIXME: It is incorrect to just clip to the damageRect here once multiple fragments are involved. 43 // FIXME: It is incorrect to just clip to the damageRect here once multiple fragments are involved.
45 44
46 // Subsequent code should not clip to the dirty rect, since we've already 45 // Subsequent code should not clip to the dirty rect, since we've already
47 // done it above, and doing it later will defeat the outsets. 46 // done it above, and doing it later will defeat the outsets.
(...skipping 29 matching lines...) Expand all
77 76
78 FilterPainter::~FilterPainter() 77 FilterPainter::~FilterPainter()
79 { 78 {
80 if (!m_filterInProgress) 79 if (!m_filterInProgress)
81 return; 80 return;
82 81
83 m_context.getPaintController().endItem<EndFilterDisplayItem>(*m_layoutObject ); 82 m_context.getPaintController().endItem<EndFilterDisplayItem>(*m_layoutObject );
84 } 83 }
85 84
86 } // namespace blink 85 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698