Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23072018: [telemetry] Move telemetry/core/chrome/ to telemetry/core/backends/chrome/ (Closed)

Created:
7 years, 4 months ago by dtu
Modified:
7 years, 3 months ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, telemetry+watch_chromium.org, chrisgao (Use stgao instead)
Visibility:
Public.

Description

[telemetry] Move telemetry/core/chrome/ to telemetry/core/backends/chrome/ This is cleanup from the addition of Webdriver support. The new folder core/backends/ will have backend interfaces that must be implemented by both Chrome and WebDriver, e.g. browser_backend; as well as backends that are common to both, e.g. form_based_credentials_backend. BUG=None. TEST=./run_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218886 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220263 R=chrisgao@chromium.org, nduca@chromium.org, tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220422

Patch Set 1 : penguin #

Total comments: 10

Patch Set 2 : Move adb_commands, png_bitmap, credentials_backends up one. #

Total comments: 2

Patch Set 3 : Merge, remove camel_case_converter #

Patch Set 4 : Merge. #

Patch Set 5 : Merge and resubmit. The conflicting test was fixed elsewhere. #

Patch Set 6 : Merge. #

Patch Set 7 : Fix perf smoothness_unittest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -4653 lines) Patch
M tools/perf/metrics/smoothness_unittest.py View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/adb_commands.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 1 2 3 4 5 6 2 chunks +4 lines, -3 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/chromeos_login_ext/main.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/chromeos_login_ext/main.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/chromeos_login_ext/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder_unittest.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/cros_interface.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/cros_interface_unittest.py View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/crx_id.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder_unittest.py View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/extension_dict_backend.py View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py View 1 2 3 4 2 chunks +9 lines, -9 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/inspector_console.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/inspector_console_unittest.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/inspector_memory.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/inspector_memory_unittest.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/inspector_network.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/inspector_page.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/inspector_page_unittest.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/inspector_runtime.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/inspector_runtime_unittest.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/inspector_timeline.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/inspector_timeline_unittest.py View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/system_info_backend.py View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/tab_list_backend.py View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/trace_result.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py View 1 2 3 4 3 chunks +6 lines, -5 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/websocket.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/websocket_browser_connection.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/chrome/websocket_unittest.py View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/facebook_credentials_backend.py View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/facebook_credentials_backend_unittest.py View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/form_based_credentials_backend.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/google_credentials_backend.py View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/google_credentials_backend_unittest.py View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
A + tools/telemetry/telemetry/core/backends/png_bitmap.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/core/backends/png_bitmap_unittest.py View 1 2 3 4 2 chunks +6 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_credentials.py View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_finder.py View 1 chunk +3 lines, -3 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/adb_commands.py View 1 2 1 chunk +0 lines, -181 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/android_browser_backend.py View 1 2 3 4 5 1 chunk +0 lines, -317 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/android_browser_finder.py View 1 2 3 4 5 6 1 chunk +0 lines, -185 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/android_browser_finder_unittest.py View 1 2 3 4 5 6 1 chunk +0 lines, -89 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/chromeos_login_ext/main.html View 1 chunk +0 lines, -9 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/chromeos_login_ext/main.js View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/chromeos_login_ext/manifest.json View 1 chunk +0 lines, -16 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/cros_browser_backend.py View 1 2 3 4 1 chunk +0 lines, -434 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/cros_browser_finder.py View 1 2 3 4 5 6 1 chunk +0 lines, -112 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/cros_browser_finder_unittest.py View 1 chunk +0 lines, -11 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/cros_interface.py View 1 chunk +0 lines, -345 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/cros_interface_unittest.py View 1 chunk +0 lines, -158 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/crx_id.py View 1 chunk +0 lines, -13 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/desktop_browser_backend.py View 1 2 3 4 5 6 1 chunk +0 lines, -247 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/desktop_browser_finder.py View 1 2 3 4 5 6 1 chunk +0 lines, -228 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/desktop_browser_finder_unittest.py View 1 2 3 4 5 6 1 chunk +0 lines, -188 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/extension_dict_backend.py View 1 chunk +0 lines, -71 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/facebook_credentials_backend.py View 1 chunk +0 lines, -32 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/facebook_credentials_backend_unittest.py View 1 chunk +0 lines, -16 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/form_based_credentials_backend.py View 1 chunk +0 lines, -110 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/form_based_credentials_backend_unittest_base.py View 1 2 3 1 chunk +0 lines, -128 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/google_credentials_backend.py View 1 chunk +0 lines, -31 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/google_credentials_backend_unittest.py View 1 chunk +0 lines, -16 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/inspector_backend.py View 1 2 3 4 1 chunk +0 lines, -326 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/inspector_console.py View 1 chunk +0 lines, -61 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/inspector_console_unittest.py View 1 2 3 1 chunk +0 lines, -34 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/inspector_memory.py View 1 chunk +0 lines, -50 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/inspector_memory_unittest.py View 1 2 3 1 chunk +0 lines, -23 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/inspector_network.py View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/inspector_page.py View 1 chunk +0 lines, -114 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/inspector_page_unittest.py View 1 2 3 1 chunk +0 lines, -53 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/inspector_runtime.py View 1 chunk +0 lines, -56 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/inspector_runtime_unittest.py View 1 chunk +0 lines, -31 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/inspector_timeline.py View 1 chunk +0 lines, -71 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/inspector_timeline_unittest.py View 1 2 3 1 chunk +0 lines, -34 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/misc_web_contents_backend.py View 1 chunk +0 lines, -38 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/png_bitmap.py View 1 2 3 4 1 chunk +0 lines, -136 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/png_bitmap_unittest.py View 1 2 3 4 1 chunk +0 lines, -78 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/system_info_backend.py View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/tab_list_backend.py View 1 chunk +0 lines, -135 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/trace_result.py View 1 chunk +0 lines, -16 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/tracing_backend.py View 1 chunk +0 lines, -132 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/tracing_backend_unittest.py View 1 2 3 1 chunk +0 lines, -89 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/websocket.py View 1 chunk +0 lines, -11 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/websocket_browser_connection.py View 1 chunk +0 lines, -59 lines 0 comments Download
D tools/telemetry/telemetry/core/chrome/websocket_unittest.py View 1 chunk +0 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/core/extension_to_load.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/extension_unittest.py View 1 2 3 3 chunks +4 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_memreport_profiler.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/java_heap_profiler.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (0 generated)
dtu
7 years, 4 months ago (2013-08-16 06:34:45 UTC) #1
nduca
lgtm
7 years, 4 months ago (2013-08-16 06:51:42 UTC) #2
tonyg
https://codereview.chromium.org/23072018/diff/3001/tools/telemetry/telemetry/core/backends/chrome/adb_commands.py File tools/telemetry/telemetry/core/backends/chrome/adb_commands.py (right): https://codereview.chromium.org/23072018/diff/3001/tools/telemetry/telemetry/core/backends/chrome/adb_commands.py#newcode1 tools/telemetry/telemetry/core/backends/chrome/adb_commands.py:1: # Copyright (c) 2012 The Chromium Authors. All rights ...
7 years, 4 months ago (2013-08-16 15:38:35 UTC) #3
chrisgao (Use stgao instead)
https://codereview.chromium.org/23072018/diff/3001/tools/telemetry/telemetry/core/backends/chrome/png_bitmap.py File tools/telemetry/telemetry/core/backends/chrome/png_bitmap.py (right): https://codereview.chromium.org/23072018/diff/3001/tools/telemetry/telemetry/core/backends/chrome/png_bitmap.py#newcode4 tools/telemetry/telemetry/core/backends/chrome/png_bitmap.py:4: import base64 webdriver_tab_backend.py uses it for screenshot.
7 years, 4 months ago (2013-08-16 18:22:22 UTC) #4
dtu
On 2013/08/16 15:38:35, tonyg wrote: > https://codereview.chromium.org/23072018/diff/3001/tools/telemetry/telemetry/core/backends/chrome/adb_commands.py > File tools/telemetry/telemetry/core/backends/chrome/adb_commands.py (right): > > https://codereview.chromium.org/23072018/diff/3001/tools/telemetry/telemetry/core/backends/chrome/adb_commands.py#newcode1 > ...
7 years, 4 months ago (2013-08-16 18:35:53 UTC) #5
tonyg
> The overall question here is, should something be placed in a folder with things ...
7 years, 4 months ago (2013-08-16 19:33:21 UTC) #6
dtu
PTAL https://codereview.chromium.org/23072018/diff/3001/tools/telemetry/telemetry/core/backends/chrome/adb_commands.py File tools/telemetry/telemetry/core/backends/chrome/adb_commands.py (right): https://codereview.chromium.org/23072018/diff/3001/tools/telemetry/telemetry/core/backends/chrome/adb_commands.py#newcode1 tools/telemetry/telemetry/core/backends/chrome/adb_commands.py:1: # Copyright (c) 2012 The Chromium Authors. All ...
7 years, 4 months ago (2013-08-16 23:33:04 UTC) #7
tonyg
lgtm https://codereview.chromium.org/23072018/diff/13001/tools/telemetry/telemetry/core/backends/chrome/camel_case_converter.py File tools/telemetry/telemetry/core/backends/chrome/camel_case_converter.py (right): https://codereview.chromium.org/23072018/diff/13001/tools/telemetry/telemetry/core/backends/chrome/camel_case_converter.py#newcode1 tools/telemetry/telemetry/core/backends/chrome/camel_case_converter.py:1: # Copyright 2013 The Chromium Authors. All rights ...
7 years, 4 months ago (2013-08-16 23:49:45 UTC) #8
dtu
https://codereview.chromium.org/23072018/diff/13001/tools/telemetry/telemetry/core/backends/chrome/camel_case_converter.py File tools/telemetry/telemetry/core/backends/chrome/camel_case_converter.py (right): https://codereview.chromium.org/23072018/diff/13001/tools/telemetry/telemetry/core/backends/chrome/camel_case_converter.py#newcode1 tools/telemetry/telemetry/core/backends/chrome/camel_case_converter.py:1: # Copyright 2013 The Chromium Authors. All rights reserved. ...
7 years, 4 months ago (2013-08-17 00:20:31 UTC) #9
chrisgao (Use stgao instead)
lgtm
7 years, 4 months ago (2013-08-17 01:06:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/23072018/44001
7 years, 4 months ago (2013-08-19 23:09:50 UTC) #11
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=161432
7 years, 4 months ago (2013-08-20 00:32:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/23072018/63001
7 years, 4 months ago (2013-08-21 18:45:52 UTC) #13
commit-bot: I haz the power
Change committed as 218886
7 years, 4 months ago (2013-08-22 00:54:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/23072018/81001
7 years, 3 months ago (2013-08-28 22:53:10 UTC) #15
commit-bot: I haz the power
Failed to apply patch for tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py: While running patch -p1 --forward --force --no-backup-if-mismatch; A tools/telemetry/telemetry/core/backends/chrome/cros_browser_finder.py ...
7 years, 3 months ago (2013-08-29 04:51:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/23072018/103001
7 years, 3 months ago (2013-08-29 08:36:36 UTC) #17
commit-bot: I haz the power
Change committed as 220263
7 years, 3 months ago (2013-08-29 11:30:48 UTC) #18
dtu
Uhm, I'm just going to manually commit, because it's clearly impossible to CQ without merge ...
7 years, 3 months ago (2013-08-29 23:02:12 UTC) #19
dtu
7 years, 3 months ago (2013-08-29 23:13:26 UTC) #20
Message was sent while issue was closed. 
Committed patchset #7 manually as r220422 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698