tools/telemetry/telemetry/core/backends/chrome/adb_commands.py - Issue 23072018: [telemetry] Move telemetry/core/chrome/ to telemetry/core/backends/chrome/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/telemetry/telemetry/core/backends/chrome/adb_commands.py

Issue 23072018: [telemetry] Move telemetry/core/chrome/ to telemetry/core/backends/chrome/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: penguin Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py » ('j') | tools/telemetry/telemetry/core/backends/chrome/camel_case_converter.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
	tonyg 2013/08/16 15:38:36 I don't think this file should live in chrome. If I don't think this file should live in chrome. If we ever supported another android browser, we'd be able to share this file as it contains methods for interacting with the android system in general, not for interacting with chrome. dtu 2013/08/16 23:33:04 Done. Show quoted text On 2013/08/16 15:38:36, tonyg wrote: > I don't think this file should live in chrome. If we ever supported another > android browser, we'd be able to share this file as it contains methods for > interacting with the android system in general, not for interacting with chrome. Done.
2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 """Brings in Chrome Android's android_commands module, which itself is a	4 """Brings in Chrome Android's android_commands module, which itself is a

5 thin(ish) wrapper around adb."""	5 thin(ish) wrapper around adb."""

6 import os	6 import os

7	7

8 from telemetry.core import util	8 from telemetry.core import util

9	9

10 # This is currently a thin wrapper around Chrome Android's	10 # This is currently a thin wrapper around Chrome Android's

11 # build scripts, located in chrome/build/android. This file exists mainly to	11 # build scripts, located in chrome/build/android. This file exists mainly to

(...skipping 158 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
170 assert HasForwarder()	170 assert HasForwarder()

171 return 'Debug' if HasForwarder('Debug') else 'Release'	171 return 'Debug' if HasForwarder('Debug') else 'Release'

172	172

173 @property	173 @property

174 def url(self):	174 def url(self):

175 return 'http://localhost:%i' % self._host_port	175 return 'http://localhost:%i' % self._host_port

176	176

177 def Close(self):	177 def Close(self):

178 for (device_port, _) in self._port_pairs:	178 for (device_port, _) in self._port_pairs:

179 forwarder.Forwarder.UnmapDevicePort(device_port, self._adb)	179 forwarder.Forwarder.UnmapDevicePort(device_port, self._adb)

OLD	NEW