Switch to using_sanitizer for archiving llvm-symbolizer. Also, add libFuzzer and AFL explicitly in …

Switch to using_sanitizer for archiving llvm-symbolizer.

R=thakis@chromium.org,dcheng@chromium.org
BUG=

Committed: https://crrev.com/b86f4f852f0daaedac285868fdad00994e348d94
Cr-Commit-Position: refs/heads/master@{#416324}

[aarya, 2016-09-02 18:21:29]

aarya@google.com changed reviewers:
+ aarya@google.com

[aarya, 2016-09-02 18:21:30]

Oliver, Max as fyi - we were missing llvm-symbolizer in libFuzzer archives.

[Nico, 2016-09-02 18:25:00]

https://codereview.chromium.org/2307103002/diff/1/build/config/sanitizers/san...
File build/config/sanitizers/sanitizers.gni (right):

https://codereview.chromium.org/2307103002/diff/1/build/config/sanitizers/san...
build/config/sanitizers/sanitizers.gni:154: use_afl || use_libfuzzer ||
use_sanitizer_coverage
Why this change? afl and libfuzzer don't mean using a sanitizer, it seems
surprising to add this here (and your bots probably use fuzzer + asan, so this
isn't needed anyways?)

[aarya, 2016-09-02 18:31:25]

Description was changed from

==========
Switch to using_sanitizer for archiving llvm-symbolizer. Also, add libFuzzer and
AFL explicitly in using_sanitizer.

R=thakis@chromium.org,dcheng@chromium.org
BUG=
==========

to

==========
Switch to using_sanitizer for archiving llvm-symbolizer. 

R=thakis@chromium.org,dcheng@chromium.org
BUG=
==========

[inferno, 2016-09-02 18:32:57]

On 2016/09/02 18:25:00, Nico wrote:
>
https://codereview.chromium.org/2307103002/diff/1/build/config/sanitizers/san...
> File build/config/sanitizers/sanitizers.gni (right):
> 
>
https://codereview.chromium.org/2307103002/diff/1/build/config/sanitizers/san...
> build/config/sanitizers/sanitizers.gni:154: use_afl || use_libfuzzer ||
> use_sanitizer_coverage
> Why this change? afl and libfuzzer don't mean using a sanitizer, it seems
> surprising to add this here (and your bots probably use fuzzer + asan, so this
> isn't needed anyways?)

You are right, i was thinking correctly here. Also, this will only fix ubsan
builders which were uncovered before. for libfuzzer, i am still confused, recipe
(https://cs.chromium.org/chromium/src/tools/mb/mb_config.pyl?rcl=0&l=1325) shows
'asan' which should mean we should archive llvm-symbolizer, but we don't

[inferno, 2016-09-02 18:33:21]

On 2016/09/02 18:32:57, inferno wrote:
> On 2016/09/02 18:25:00, Nico wrote:
> >
>
https://codereview.chromium.org/2307103002/diff/1/build/config/sanitizers/san...
> > File build/config/sanitizers/sanitizers.gni (right):
> > 
> >
>
https://codereview.chromium.org/2307103002/diff/1/build/config/sanitizers/san...
> > build/config/sanitizers/sanitizers.gni:154: use_afl || use_libfuzzer ||
> > use_sanitizer_coverage
> > Why this change? afl and libfuzzer don't mean using a sanitizer, it seems
> > surprising to add this here (and your bots probably use fuzzer + asan, so
this
> > isn't needed anyways?)
> 
> You are right, i was thinking correctly here. Also, this will only fix ubsan
> builders which were uncovered before. for libfuzzer, i am still confused,
recipe
> (https://cs.chromium.org/chromium/src/tools/mb/mb_config.pyl?rcl=0&l=1325)
shows
> 'asan' which should mean we should archive llvm-symbolizer, but we don't

s/was thinking/wasn't thinking

[Nico, 2016-09-02 18:37:14]

patch set 2 lgtm

[inferno, 2016-09-02 18:40:58]

The CQ bit was checked by inferno@chromium.org

[commit-bot: I haz the power, 2016-09-02 18:41:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[inferno, 2016-09-02 18:43:02]

Not archiving for libfuzzer is another issue (copy_llvm_symbolizer hack in
different places for linux, chromium_builder_asan target; so that is why not
work on mac libfuzzer), but this one is good for ubsan, so cqing.

[commit-bot: I haz the power, 2016-09-02 19:58:49]

Description was changed from

==========
Switch to using_sanitizer for archiving llvm-symbolizer. 

R=thakis@chromium.org,dcheng@chromium.org
BUG=
==========

to

==========
Switch to using_sanitizer for archiving llvm-symbolizer. 

R=thakis@chromium.org,dcheng@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-09-02 19:58:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-02 20:00:53]

Description was changed from

==========
Switch to using_sanitizer for archiving llvm-symbolizer. 

R=thakis@chromium.org,dcheng@chromium.org
BUG=
==========

to

==========
Switch to using_sanitizer for archiving llvm-symbolizer.

R=thakis@chromium.org,dcheng@chromium.org
BUG=

Committed: https://crrev.com/b86f4f852f0daaedac285868fdad00994e348d94
Cr-Commit-Position: refs/heads/master@{#416324}
==========

[commit-bot: I haz the power, 2016-09-02 20:00:54]

Patchset 2 (id:??) landed as
https://crrev.com/b86f4f852f0daaedac285868fdad00994e348d94
Cr-Commit-Position: refs/heads/master@{#416324}