Switch to using_sanitizer for archiving llvm-symbolizer. Also, add libFuzzer and AFL explicitly in …

build/config/sanitizers/sanitizers.gni

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 
 declare_args() {
   # Compile for Address Sanitizer to find memory bugs.
   is_asan = false
 
@@ skipping 131 matching lines @@
   # Mac: http://crbug.com/352073
   asan_globals = !is_android && !is_mac
 }
 
 if (use_afl && sanitizer_coverage_flags == "") {
   sanitizer_coverage_flags = "trace-pc"
 } else if (use_sanitizer_coverage && sanitizer_coverage_flags == "") {
   sanitizer_coverage_flags = "edge,indirect-calls,8bit-counters"
 }
 
-using_sanitizer =
-    is_asan || is_lsan || is_tsan || is_msan || is_ubsan || is_ubsan_null ||
-    is_ubsan_vptr || is_ubsan_security || use_sanitizer_coverage
+using_sanitizer = is_asan || is_lsan || is_tsan || is_msan || is_ubsan ||
+                  is_ubsan_null || is_ubsan_vptr || is_ubsan_security ||
+                  use_afl || use_libfuzzer || use_sanitizer_coverage

[Nico, 2016/09/02 18:25:00]

Why this change? afl and libfuzzer don't mean using a sanitizer, it seems
surprising to add this here (and your bots probably use fuzzer + asan, so this
isn't needed anyways?)

 
 assert(!using_sanitizer || is_clang,
        "Sanitizers (is_*san) require setting is_clang = true in 'gn args'")
 
 prebuilt_instrumented_libraries_available =
     is_msan && (msan_track_origins == 0 || msan_track_origins == 2)
 
 # MSan only links Chrome properly in release builds (brettw -- 9/1/2015). The
 # same is possibly true for the other non-ASan sanitizers. But regardless of
 # whether it links, one would normally never run a sanitizer in debug mode.
 # Running in debug mode probably indicates you forgot to set the "is_debug =
 # false" flag in the build args. ASan seems to run fine in debug mode.
 #
 # If you find a use-case where you want to compile a sanitizer in debug mode
 # and have verified it works, ask brettw and we can consider removing it from
 # this condition. We may also be able to find another way to enable your case
 # without having people accidentally get broken builds by compiling an
 # unsupported or unadvisable configurations.
 #
 # For one-off testing, just comment this assertion out.
 assert(!is_debug || !(is_msan || is_ubsan || is_ubsan_null || is_ubsan_vptr),
        "Sanitizers should generally be used in release (set is_debug=false).")
 
 assert(!is_msan || (is_linux && current_cpu == "x64"),
        "MSan currently only works on 64-bit Linux and ChromeOS builds.")