Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2307003002: Move collectGarbage* methods to ThreadState (Closed)

Created:
4 years, 3 months ago by keishi
Modified:
4 years, 3 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, shans, dshwang, eae+blinkwatch, apavlov+blink_chromium.org, kinuko+watch, rwlbuis, Mads Ager (chromium), blink-reviews-css, blink-reviews-html_chromium.org, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, blink-reviews, Eric Willigers, rjwright, blink-reviews-style_chromium.org, sof, darktears, haraken, jsbell+idb_chromium.org, ajuma+watch-canvas_chromium.org, blink-reviews-animation_chromium.org, loading-reviews+parser_chromium.org, cmumford, oilpan-reviews, kouhei+heap_chromium.org, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move collectGarbage* methods to ThreadState Move collectGarbage* methods to ThreadState to indicate that these run GC for the current thread heap. BUG= Committed: https://crrev.com/89d83a49a6c126d91e25e2d3520cb398e8e1f7d5 Committed: https://crrev.com/f7a7635e3c139b0230d4ac74bdb517ded2e26385 Cr-Original-Commit-Position: refs/heads/master@{#417269} Cr-Commit-Position: refs/heads/master@{#417538}

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 2

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -278 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationInputHelpersTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationStackTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimelineTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/DocumentTimelineTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheetResourceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStatisticsCollectorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContextTaskTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngineTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/AutoplayExperimentTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/CSSPreloadScannerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintWorkletTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BytesConsumerForDataConsumerHandleTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerTeeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/LifecycleContextTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 2 chunks +0 lines, -170 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 7 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PersistentTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/RunAllTests.cpp View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 2 11 chunks +224 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/mhtml/MHTMLFuzzer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/CancellableTaskFactoryTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeAuraTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/RunAllTests.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebHeap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 28 (16 generated)
keishi
4 years, 3 months ago (2016-09-07 10:05:54 UTC) #7
haraken
LGTM https://codereview.chromium.org/2307003002/diff/20001/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp File third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp (right): https://codereview.chromium.org/2307003002/diff/20001/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp#newcode355 third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp:355: if (currentThreadState && !ThreadState::current()->isGCForbidden()) { ThreadState::current() => currentThread
4 years, 3 months ago (2016-09-07 14:38:55 UTC) #8
keishi
https://codereview.chromium.org/2307003002/diff/20001/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp File third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp (right): https://codereview.chromium.org/2307003002/diff/20001/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp#newcode355 third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp:355: if (currentThreadState && !ThreadState::current()->isGCForbidden()) { On 2016/09/07 14:38:55, haraken ...
4 years, 3 months ago (2016-09-08 01:48:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307003002/40001
4 years, 3 months ago (2016-09-08 01:48:37 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/289376)
4 years, 3 months ago (2016-09-08 06:18:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307003002/40001
4 years, 3 months ago (2016-09-08 08:17:04 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-08 13:21:03 UTC) #18
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/89d83a49a6c126d91e25e2d3520cb398e8e1f7d5 Cr-Commit-Position: refs/heads/master@{#417269}
4 years, 3 months ago (2016-09-08 13:23:44 UTC) #20
dmurph
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2321223003/ by dmurph@chromium.org. ...
4 years, 3 months ago (2016-09-08 22:05:09 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307003002/40001
4 years, 3 months ago (2016-09-09 07:38:43 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-09 09:05:05 UTC) #26
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 09:07:21 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f7a7635e3c139b0230d4ac74bdb517ded2e26385
Cr-Commit-Position: refs/heads/master@{#417538}

Powered by Google App Engine
This is Rietveld 408576698